https://bugzilla.redhat.com/show_bug.cgi?id=1306629
Bug ID: 1306629 Summary: Review Request: metrics-reporter-config - Manages config for Coda Hale’s Metrics-reporter Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: trepik@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://trepik.fedorapeople.org/metrics-reporter-config.spec SRPM URL: https://trepik.fedorapeople.org/metrics-reporter-config-3.0.0-1.fc23.src.rpm
Description: To package cassandra for fedora metrics-reporter-config is required. Metrics-Reporter-Config aims to provide a simple way to configure and enable a set of Reporters that can be shared among applications. It should fit most (say 90% of) use cases and avoid situations like a plethora of subtly incompatible properties files.
Fedora Account System Username: trepik
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
Tomas Repik trepik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR), | |652183 (FE-JAVASIG)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
Tomas Repik trepik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |puntogil@libero.it Assignee|nobody@fedoraproject.org |puntogil@libero.it Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
--- Comment #1 from gil cattaneo puntogil@libero.it --- I has escaped those who sponsored you, you can tell me who was sponsoring you?
Some unblocking issues:
Please, remove %pom_change_dep io.dropwizard.metrics: com.codahale.metrics: reporter-config3/pom.xml in Fedora 24 and major this is unnecessary
Please change Buildrequires: mvn(org.yaml:snakeyaml) in BuildRequires: mvn(org.yaml:snakeyaml)
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
--- Comment #2 from gil cattaneo puntogil@libero.it --- ... sorry for the noise, missing BuildRequires: mvn(org.apache.commons:commons-lang3)
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #3 from gil cattaneo puntogil@libero.it --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache (v2.0)". 6 files have unknown license. Detailed output of licensecheck in /home/gil/1306629-metrics-reporter-config/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: metrics-reporter-config (description) [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in metrics- reporter-config-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: metrics-reporter-config-3.0.0-1.fc25.noarch.rpm metrics-reporter-config-javadoc-3.0.0-1.fc25.noarch.rpm metrics-reporter-config-3.0.0-1.fc25.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Requires -------- metrics-reporter-config-javadoc (rpmlib, GLIBC filtered): javapackages-tools
metrics-reporter-config (rpmlib, GLIBC filtered): java-headless javapackages-tools mvn(com.codahale.metrics:metrics-core) mvn(org.apache.commons:commons-lang3) mvn(org.hibernate:hibernate-validator) mvn(org.slf4j:slf4j-api) mvn(org.yaml:snakeyaml)
Provides -------- metrics-reporter-config-javadoc: metrics-reporter-config-javadoc
metrics-reporter-config: metrics-reporter-config mvn(com.addthis.metrics:reporter-config) mvn(com.addthis.metrics:reporter-config-base) mvn(com.addthis.metrics:reporter-config-base:pom:) mvn(com.addthis.metrics:reporter-config-parent:pom:) mvn(com.addthis.metrics:reporter-config3) mvn(com.addthis.metrics:reporter-config3:pom:) mvn(com.addthis.metrics:reporter-config:pom:)
Source checksums ---------------- https://github.com/addthis/metrics-reporter-config/archive/v3.0.0.tar.gz : CHECKSUM(SHA256) this package : 857683a4358a744f2490c7e5542adcff78c73c90c3ee5af2fefa9fe8e087ea40 CHECKSUM(SHA256) upstream package : 857683a4358a744f2490c7e5542adcff78c73c90c3ee5af2fefa9fe8e087ea40
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1306629 --plugins Java -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
--- Comment #4 from gil cattaneo puntogil@libero.it --- Blocking issues: [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache (v2.0)". 6 files have unknown license. Detailed output of licensecheck in /home/gil/1306629-metrics-reporter-config/licensecheck.txt
The following source files are without license headers: metrics-reporter-config-3.0.0/reporter-config2/src/main/java/com/addthis/metrics/reporter/config/MetricPredicateTransformer.java metrics-reporter-config-3.0.0/reporter-config2/src/test/java/com/addthis/metrics/reporter/config/GraphiteReporterConfigTest.java metrics-reporter-config-3.0.0/reporter-config3/src/main/java/com/addthis/metrics3/reporter/config/MetricFilterTransformer.java metrics-reporter-config-3.0.0/reporter-config3/src/test/java/com/addthis/metrics3/reporter/config/GraphiteReporterConfigTest.java
Please, ask to upstream to include license headers where are missing
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/Li...
Non blocking issues: see Comment#1 and comment#2
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
--- Comment #5 from Tomas Repik trepik@redhat.com --- I asked upstream for the headers: https://github.com/addthis/metrics-reporter-config/issues/18
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
--- Comment #6 from gil cattaneo puntogil@libero.it --- (In reply to Tomas Repik from comment #5)
I asked upstream for the headers: https://github.com/addthis/metrics-reporter-config/issues/18
Ok, thanks. When you settle other issues approved the package
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
--- Comment #7 from Tomas Repik trepik@redhat.com --- Spec URL: https://trepik.fedorapeople.org/metrics-reporter-config/v1/metrics-reporter-... SRPM URL: https://trepik.fedorapeople.org/metrics-reporter-config/v1/metrics-reporter-...
* Wed Mar 23 2016 Tomas Repik trepik@redhat.com - 3.0.0-2 - added buildrequires, comment for fedora 24 and typo fix
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #8 from gil cattaneo puntogil@libero.it --- Thanks. Approved Have time for this https://bugzilla.redhat.com/show_bug.cgi?id=1286467 ?
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
--- Comment #9 from Tomas Repik trepik@redhat.com --- Spec URL: https://trepik.fedorapeople.org/metrics-reporter-config/v2/metrics-reporter-... SRPM URL: https://trepik.fedorapeople.org/metrics-reporter-config/v2/metrics-reporter-...
Just reset the release number, here is the diff:
--- SPECS/old/metrics-reporter-config.spec 2016-03-24 08:58:10.952502015 +0100 +++ SPECS/metrics-reporter-config.spec 2016-03-24 09:01:14.670278552 +0100 @@ -1,6 +1,6 @@ Name: metrics-reporter-config Version: 3.0.0 -Release: 2%{?dist} +Release: 1%{?dist} Summary: Manages config for metrics from Coda Hale’s Metrics library
License: ASL 2.0 @@ -71,9 +71,6 @@ %license LICENSE NOTICE
%changelog -* Wed Mar 23 2016 Tomas Repik trepik@redhat.com - 3.0.0-2 -- added buildrequires, comment for fedora 24 and typo fix - -* Thu Feb 11 2016 Tomas Repik trepik@redhat.com - 3.0.0-1 +* Wed Mar 23 2016 Tomas Repik trepik@redhat.com - 3.0.0-1 - Initial RPM release
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
--- Comment #10 from gil cattaneo puntogil@libero.it --- I think that you should be undo these changes. I don't understand the reasons(In reply to Tomas Repik from comment #9)
Spec URL: https://trepik.fedorapeople.org/metrics-reporter-config/v2/metrics-reporter- config.spec SRPM URL: https://trepik.fedorapeople.org/metrics-reporter-config/v2/metrics-reporter- config-3.0.0-1.fc23.src.rpm
Just reset the release number, here is the diff:
--- SPECS/old/metrics-reporter-config.spec 2016-03-24 08:58:10.952502015 +0100 +++ SPECS/metrics-reporter-config.spec 2016-03-24 09:01:14.670278552 +0100 @@ -1,6 +1,6 @@ Name: metrics-reporter-config Version: 3.0.0 -Release: 2%{?dist} +Release: 1%{?dist} Summary: Manages config for metrics from Coda Hale’s Metrics library
License: ASL 2.0 @@ -71,9 +71,6 @@ %license LICENSE NOTICE
%changelog -* Wed Mar 23 2016 Tomas Repik trepik@redhat.com - 3.0.0-2 -- added buildrequires, comment for fedora 24 and typo fix
-* Thu Feb 11 2016 Tomas Repik trepik@redhat.com - 3.0.0-1 +* Wed Mar 23 2016 Tomas Repik trepik@redhat.com - 3.0.0-1
- Initial RPM release
I think that you should be undo these changes. I don't understand the reasons
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
--- Comment #11 from Tomas Repik trepik@redhat.com --- (In reply to gil cattaneo from comment #10)
I think that you should be undo these changes. I don't understand the reasons
I was advised that it is good practice to reset release number upon first release of a package.
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
--- Comment #12 from gil cattaneo puntogil@libero.it --- (In reply to Tomas Repik from comment #11)
I was advised that it is good practice to reset release number upon first release of a package.
This ..., is the first time i hear it in Fedora, and it seems so hopeless
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
--- Comment #13 from gil cattaneo puntogil@libero.it --- I remain of you do not change the entries in the changelog
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
--- Comment #14 from Till Maas opensource@till.name --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/metrics-reporter-config
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- metrics-reporter-config-3.0.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f12e1b0f22
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- metrics-reporter-config-3.0.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f12e1b0f22
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
Tomas Repik trepik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1324020
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1324020 [Bug 1324020] Review Request: cassandrsa - OpenSource database Apache Cassandra
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- metrics-reporter-config-3.0.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-04-07 11:50:36
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
Tomas Repik trepik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|1324020 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1324020 [Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|652183 (FE-JAVASIG) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- metrics-reporter-config-3.0.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-60a5bca291
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|ERRATA |--- Keywords| |Reopened
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- metrics-reporter-config-3.0.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-60a5bca291
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- metrics-reporter-config-3.0.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1306629
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2016-04-07 11:50:36 |2016-06-30 17:27:48
package-review@lists.fedoraproject.org