https://bugzilla.redhat.com/show_bug.cgi?id=1065745
--- Comment #9 from Leon Weber <leon(a)leonweber.de> ---
This fails to build:
error: Installed (but unpackaged) file(s) found:
/usr/share/doc/lltag/COPYING
/usr/share/doc/lltag/Changes
/usr/share/doc/lltag/README
This happens because you copy these files to %{_docdir} in the %install
section. In the %files section, however, you don’t reference the files in
%{_docdir} but the ones directly in $RPM_BUILD_ROOT. Just drop the cp line and
the mkdir from the %install section and you should be good.
Some more minor issues:
The Summary line doesn’t need to repeat the package name (e.g. “A frontend to
tag…” instead of “lltag is a frontend to tag…”).
Nitpicking: There’s still _one_ tab character in the spec file, after the colon
in line 9, followed by seven space characters. ;-)
Break the description field into multiple lines of <= 80 characters each.
Run rpmlint to test for these things: See
<
http://fedoraproject.org/wiki/How_to_create_an_RPM_package#Test_with_rpml...
and the following sections.
Btw, you should stick to the format from the template for posting links to spec
and rpm files, so that the fedora-review tool can pick them up automatically:
Spec URL:
http://ofosos.org/lltag.spec
SRPM URL:
http://ofosos.org/lltag-0.14.4-2.fc20.src.rpm
That way you don’t risk a reviewer accidentally reviewing an old version
(fedora-review picks the latest URL it can find).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component