Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Perlbal - Reverse-proxy load balancer and webserver
Alias: Perlbal
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240693
tibbs(a)math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From tibbs(a)math.uh.edu 2007-07-27 22:38 EST -------
rpmlint says:
W: Perlbal mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 10)
which is no big deal; fix it if you like.
You probably want to use "perl" instead of "%{__perl}" in your
specfile;
otherwise you should be consistent and use %{__make}, %{__rm}, %{__mv}, etc.
Since that's the only real issue, I'll approve this and you can fix it when you
check in.
Review:
* source files match upstream:
974d684dd02b0a04f8203ff407c876cc1b253ba5066c7673e232dab850a07922
Perlbal-1.59.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named.
X specfile does not use macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint has only acceptable complaints.
* final provides and requires are sane:
config(Perlbal) = 1.59-1.fc8
perl(PalImg)
perl(PaletteModify)
perl(Perlbal) = 1.59
perl(Perlbal::AIO)
perl(Perlbal::BackendHTTP)
perl(Perlbal::Cache) = 1.0
perl(Perlbal::ChunkedUploadState)
perl(Perlbal::ClientHTTP)
perl(Perlbal::ClientHTTPBase)
perl(Perlbal::ClientManage)
perl(Perlbal::ClientProxy)
perl(Perlbal::CommandContext)
perl(Perlbal::HTTPHeaders)
perl(Perlbal::ManageCommand)
perl(Perlbal::Plugin::AccessControl)
perl(Perlbal::Plugin::AutoRemoveLeadingDir)
perl(Perlbal::Plugin::EchoService)
perl(Perlbal::Plugin::EchoService::Client)
perl(Perlbal::Plugin::Highpri)
perl(Perlbal::Plugin::LazyCDN)
perl(Perlbal::Plugin::NotModified)
perl(Perlbal::Plugin::Palimg)
perl(Perlbal::Plugin::Queues)
perl(Perlbal::Plugin::Stats)
perl(Perlbal::Plugin::Stats::Storage)
perl(Perlbal::Plugin::Vhosts)
perl(Perlbal::Pool)
perl(Perlbal::ReproxyManager)
perl(Perlbal::Service)
perl(Perlbal::Socket)
perl(Perlbal::TCPListener)
perl(Perlbal::Test)
perl(Perlbal::Test::WebClient)
perl(Perlbal::Test::WebServer)
perl(Perlbal::UploadListener)
perl(Perlbal::Util)
Perlbal = 1.59-1.fc8
=
/bin/bash
/bin/sh
/sbin/chkconfig
/sbin/service
/usr/bin/perl
config(Perlbal) = 1.59-1.fc8
perl(:MODULE_COMPAT_5.8.8)
perl(BSD::Resource)
perl(Carp)
perl(Danga::Socket) >= 1.44
perl(Devel::Peek)
perl(Errno)
perl(Exporter)
perl(Fcntl)
perl(File::Path)
perl(Getopt::Long)
perl(HTTP::Date)
perl(HTTP::Request)
perl(HTTP::Response)
perl(IO::AIO)
perl(IO::File)
perl(IO::Handle)
perl(IO::Socket)
perl(IO::Socket::INET)
perl(POSIX)
perl(Perlbal)
perl(Perlbal::AIO)
perl(Perlbal::BackendHTTP)
perl(Perlbal::Cache)
perl(Perlbal::ChunkedUploadState)
perl(Perlbal::ClientHTTP)
perl(Perlbal::ClientHTTPBase)
perl(Perlbal::ClientManage)
perl(Perlbal::ClientProxy)
perl(Perlbal::CommandContext)
perl(Perlbal::HTTPHeaders)
perl(Perlbal::ManageCommand)
perl(Perlbal::Pool)
perl(Perlbal::ReproxyManager)
perl(Perlbal::Service)
perl(Perlbal::Socket)
perl(Perlbal::TCPListener)
perl(Perlbal::Test)
perl(Perlbal::Test::WebClient)
perl(Perlbal::UploadListener)
perl(Perlbal::Util)
perl(Scalar::Util)
perl(Socket)
perl(Storable)
perl(Sys::Syscall)
perl(Time::HiRes)
perl(base)
perl(constant)
perl(fields)
perl(lib)
perl(strict)
perl(vars)
perl(warnings)
* %check is present and all tests pass:
All tests successful, 1 test skipped.
Files=17, Tests=406, 40 wallclock secs ( 1.83 cusr + 0.59 csys = 2.42 CPU)
(One test is skipped intentionally.)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets OK (chkconfig calls from ScriptletSnippets).
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
APPROVED
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.