Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345
Summary: Review Request: kodos - Visual regular expression editor Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: icon@fedoraproject.org QAContact: fedora-package-review@redhat.com
Spec URL: http://blues.mcgill.ca/~icon/fe/kodos.spec SRPM URL: http://blues.mcgill.ca/~icon/fe/kodos-2.4.9-1.src.rpm Description: Kodos is a visual regular expression editor and debugger written in Python.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kodos - Visual regular expression editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345
orion@cora.nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |orion@cora.nwra.com OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From orion@cora.nwra.com 2007-01-30 13:45 EST ------- Mostly looks good, full review to follow but thought I'd note this first:
# rpmlint -i kodos E: kodos non-executable-script /usr/lib/python2.4/site-packages/kodos/kodos.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere.
I think you want to pull the shebang. Or, perhaps not even package it as it is basically the same as /usr/bin/kodos?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kodos - Visual regular expression editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345
------- Additional Comments From orion@cora.nwra.com 2007-01-30 14:01 EST ------- mock build fails:
+ desktop-file-install --vendor fedora --dir /var/tmp/kodos-2.4.9-1.fc6-root-mockbuild/usr/share/applications --add-category X-Fedora /builddir/build/SOURCES/kodos.desktop /var/tmp/rpm-tmp.24776: line 36: desktop-file-install: command not found
Looks like you need:
BuildRequires: desktop-file-utils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kodos - Visual regular expression editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345
orion@cora.nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(icon@fedoraproject | |.org)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kodos - Visual regular expression editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345
icon@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(icon@fedoraproject| |.org) |
------- Additional Comments From icon@fedoraproject.org 2007-03-11 11:39 EST ------- I apologize for the delay. This is tested to build in mock, pass all rpmlint checks, and known to work. :)
http://blues.mcgill.ca/~icon/fe/kodos.spec http://blues.mcgill.ca/~icon/fe/kodos-2.4.9-2.fc6.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kodos - Visual regular expression editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345
orion@cora.nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |fedora-review-, | |needinfo?(icon@fedoraproject | |.org)
------- Additional Comments From orion@cora.nwra.com 2007-03-12 12:49 EST ------- Good:
- rpmlint checks return:
*
- package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime
Worrisome:
- There is no license/copyright/author information in the source files themselves. Please ping upstream about getting this added. Not a blocker per se, since the project clearly inteads to be GPLv2.
Fix:
- No need for X-Fedora in desktop-file-install - No need for update-desktop-database - no MimeType key in .desktop file (http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?highlight=%28updat...)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kodos - Visual regular expression editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium
icon@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(icon@fedoraproject| |.org) |
------- Additional Comments From icon@fedoraproject.org 2007-06-10 17:34 EST ------- Sorry for the delay, again. I swear it will be speedy from now on. :)
http://blues.mcgill.ca/~icon/fe/kodos.spec http://blues.mcgill.ca/~icon/fe/kodos-2.4.9-3.el5.wsg.src.rpm
Cheers!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kodos - Visual regular expression editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345
orion@cora.nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 | nThis| | Flag|fedora-review- |fedora-review+
------- Additional Comments From orion@cora.nwra.com 2007-06-12 16:41 EST ------- Looks good to me. I would change:
%{_bindir}/* %{python_sitelib}/* %{_datadir}/applications/*
to:
%{_bindir}/kodos %{_python_sitelib}/kodos/ %{_datadir}/applications/fedora-kodos.desktop
because personally I like to list things out. Helps detect when things change. But I'll leave that up to your preference.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kodos - Visual regular expression editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345
mricon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From mricon@gmail.com 2007-06-15 10:32 EST ------- New Package CVS Request ======================= Package Name: kodos Short Description: Visual regular expression editor Owners: icon@fedoraproject.org Branches: FC-6 F-7 EL-5 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kodos - Visual regular expression editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-06-15 23:41 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kodos - Visual regular expression editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-06-16 11:23 EST -------
From cvs commit log:
Requires(post): desktop-file-utils Requires(postun): desktop-file-utils
However, there is no %post or %postun.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: kodos - Visual regular expression editor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225345
mricon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From mricon@gmail.com 2007-06-17 13:13 EST ------- Thanks, everyone!
package-review@lists.fedoraproject.org