Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: l7-protocols - Protocol definitions files for l7-filter
https://bugzilla.redhat.com/show_bug.cgi?id=526263
Summary: Review Request: l7-protocols - Protocol definitions files for l7-filter Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mail@marcus-moeller.ch QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://www.marcus-moeller.de/share/build/l7-protocols/l7-protocols.spec SRPM URL: http://www.marcus-moeller.de/share/build/l7-protocols/l7-protocols-20090528-... Description:
L7-filter is a packet classifier for Linux. Unlike most other classifiers, it doesn't just look at simple values such as port numbers but does regular expression matching on the application layer data to determine what protocols are being used.
This package contains the protocol definitions files for use with the Linux Layer 7 Packet Classifier. These files are regular expressions that define Internet protocols, including HTTP, FTP, DNS, P2P filesharing, etc.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
Marcus Moeller mail@marcus-moeller.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |526265
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
Christoph Wickert cwickert@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |cwickert@fedoraproject.org AssignedTo|nobody@fedoraproject.org |cwickert@fedoraproject.org Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
--- Comment #1 from Marcus Moeller mail@marcus-moeller.ch 2009-10-05 10:13:24 EDT --- rpmlint {SPECS,SRPMS,RPMS/noarch}/l7-protocols*
l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/chikka-b-1 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/chikka-b-3 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/chikka-b-5 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/chikka-b-7 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/gnutella-connect-2 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/http-wunderground-2 l7-protocols.noarch: W: file-not-utf8 /usr/share/doc/l7-protocols-20090528/testing/data/http-wunderground-2 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/http-wunderground-1 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/ftp-2 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/imap-4 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/imap-6 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/ftp-3 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/http-digg-304-2 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/chikka-b-2 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/chikka-b-4 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/chikka-a-2 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/chikka-a-1 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/chikka-a-3 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/example_traffic/msn_chat_and_file_transfer.txt l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/imap-5 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/imap-2 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/chikka-b-6 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/ssdp-1 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/imap-3 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/gnutella-3 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/gnutella-2 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/gnutella-1 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/ftp-4 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/ftp-5 l7-protocols.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/l7-protocols-20090528/testing/data/ftp-1 2 packages and 1 specfiles checked; 0 errors, 30 warnings.
Still got a few warnings concerning the file format. I have asked upstream if it's necessary to keep the tests in the original encoding.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
--- Comment #2 from Marcus Moeller mail@marcus-moeller.ch 2009-10-07 04:53:35 EDT --- Update:
The above files are byte for byte transcripts of network data and must not be changed in any way.
Best Regards Marcus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
--- Comment #3 from Marcus Moeller mail@marcus-moeller.ch 2009-10-09 03:45:31 EDT --- Made custom README replaceable as it needs to be updated on package version changes.
Spec URL: http://www.marcus-moeller.de/share/build/l7-protocols/20090528-2/l7-protocol... SRPM URL: http://www.marcus-moeller.de/share/build/l7-protocols/20090528-2/l7-protocol...
Best Regards Marcus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
--- Comment #4 from Christoph Wickert cwickert@fedoraproject.org 2009-11-03 19:47:54 EDT --- Marcus, what happened to your server? All the files are returning 404.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
--- Comment #5 from Marcus Moeller mail@marcus-moeller.ch 2009-11-04 06:20:21 EDT --- Should work again. Sorry.
Best Regards Marcus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
--- Comment #6 from Marcus Moeller mail@marcus-moeller.ch 2009-11-13 02:12:37 EDT --- Contacted the author concerning the tests
He stated that they are only for testing the speeds of the patterns and are completely unnecessary for production running and that it would not make a sense to make a separate package for them.
This is why tests have now been removed from the package.
Spec URL: http://www.marcus-moeller.de/share/build/l7-protocols/20090528-3/l7-protocol... SRPM URL: http://www.marcus-moeller.de/share/build/l7-protocols/20090528-3/l7-protocol...
Best Regards Marcus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp
--- Comment #7 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-11-17 13:48:47 EDT --- @Christoph:
Currently I am reviewing another review request by Marcus (bug 530301), which I think can be approved with a few left work. Would you tell me if you are going to sponsor Marcus or not?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
--- Comment #8 from Christoph Wickert cwickert@fedoraproject.org 2009-11-17 15:09:19 EDT --- I am definitely going to sponsor Marcus, but the l7 packages still need a lot work. Marcus and I have talked about this on IRC and in private, sorry it's not in bugzilla.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
--- Comment #9 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-11-18 11:11:50 EDT --- (In reply to comment #8)
I am definitely going to sponsor Marcus, but the l7 packages still need a lot work. Marcus and I have talked about this on IRC and in private, sorry it's not in bugzilla.
Well, then will you sponsor Marcus soon if he applies for the sponsorship? Now bmpanel2 review request (bug 530301) can be approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
--- Comment #10 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-11-22 22:30:41 EDT --- Christoph?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
--- Comment #11 from Marcus Moeller mail@marcus-moeller.ch 2009-11-26 04:50:47 EDT --- Reworked. Christoph suggested in IRC to include the tests and to place the protocols in %{_datadir} instead of docs.
Spec URL: http://www.marcus-moeller.de/share/build/l7-protocols/20090528-4/l7.spec SRPM URL: http://www.marcus-moeller.de/share/build/l7-protocols/20090528-4/l7-20090528...
Best Regards Marcus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
--- Comment #12 from Marcus Moeller mail@marcus-moeller.ch 2009-12-17 03:29:00 EDT --- Debian Guys had similar discussion about placing the protocol definitions:
They've ended up with the simplest solution: protocol definitions are put in /etc and they are marked as conffiles.
http://bugs.debian.org/546665 http://lists.debian.org/debian-devel/2009/09/msg00860.html http://www.debian.org/doc/debian-policy/ap-pkg-conffiles.html#sE.1
I personally prefer to place them into %{_datadir}.
Besides that, the package has been updated: - made tests the main package and defined named subpackage
Spec URL: http://www.marcus-moeller.de/share/build/l7-protocols/20090528-5/l7-tests.sp... SRPM URL: http://www.marcus-moeller.de/share/build/l7-protocols/20090528-5/l7-tests-20...
rpmlint SRPMS/l7-tests-20090528-5.fc11.src.rpm RPMS/noarch/l7-protocols-20090528-5.fc11.noarch.rpm RPMS/i586/l7-tests-debuginfo-20090528-5.fc11.i586.rpm RPMS/i586/l7-tests-20090528-5.fc11.i586.rpm l7-tests-debuginfo.i586: E: debuginfo-without-sources
Not sure how to get rid of these debuginfo-without-sources message.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
--- Comment #13 from Christoph Wickert cwickert@fedoraproject.org 2010-04-02 17:59:41 EDT --- (In reply to comment #12)
Not sure how to get rid of these debuginfo-without-sources message.
This is most likely because you are not using the proper rpm optflags. Please take a look at https://fedoraproject.org/wiki/Packaging:Debuginfo and https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
Christoph Wickert cwickert@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Blocks| |201449(FE-DEADREVIEW) Resolution| |NOTABUG Flag|fedora-review? |
--- Comment #14 from Christoph Wickert cwickert@fedoraproject.org 2010-07-16 14:31:40 EDT --- As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews I'm now closing this bug. Feel free to reopen once the packages are ready. Don't forget to remove the block on FE-DEADREVIEW then.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
--- Comment #15 from Marcus Moeller marcus.moeller@gmx.ch 2011-08-04 08:25:03 EDT --- Updated package, to not include tests as they are not needed.
http://www.marcusmoeller.ch/share/build/l7-protocols/20090528-6/l7-protocols... http://www.marcusmoeller.ch/share/build/l7-protocols/20090528-6/l7-protocols...
This is also in line with the Debian package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
Marcus Moeller marcus.moeller@gmx.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|NOTABUG | Keywords| |Reopened
--- Comment #16 from Marcus Moeller marcus.moeller@gmx.ch 2011-08-04 11:01:37 EDT --- http://www.marcusmoeller.ch/share/build/l7-filter-userspace/0.12-0.1.beta1/l... http://www.marcusmoeller.ch/share/build/l7-filter-userspace/0.12-0.1.beta1/l...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
--- Comment #17 from Marcus Moeller marcus.moeller@gmx.ch 2011-08-04 11:02:18 EDT --- Sorry, the last past should go to the filter package :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
Marcus Moeller marcus.moeller@gmx.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|201449(FE-DEADREVIEW) |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526263
--- Comment #18 from Marcus Moeller marcus.moeller@gmx.ch 2011-08-04 11:28:22 EDT --- Atm, i have placed the protocols in /usr/share but some ppl suggest to use /usr/lib instead:
http://www.marcusmoeller.ch/share/build/l7-protocols/share_vs_lib
I leave the decision up to you cwickert, just leave me a note here and i will prepare an updated version that makes use of /usr/lib, instead.
package-review@lists.fedoraproject.org