https://bugzilla.redhat.com/show_bug.cgi?id=1121119
Bug ID: 1121119 Summary: Review Request: rubygem-gyoku - Translates Ruby Hashes to XML Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: steve.traylen@cern.ch QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://cern.ch/straylen/rpms/rubygem-gyoku/rubygem-gyoku.spec SRPM URL: http://cern.ch/straylen/rpms/rubygem-gyoku/rubygem-gyoku-1.1.1-1.fc20.src.rp... Description: Gyoku translates Ruby Hashes to XML. Fedora Account System Username: stevetraylen
https://bugzilla.redhat.com/show_bug.cgi?id=1121119
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1121120
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1121120 [Bug 1121120] Review Request: rubygem-akami - Web Service Security
https://bugzilla.redhat.com/show_bug.cgi?id=1121119
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1121125
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1121125 [Bug 1121125] Review Request: rubygem-savon - Heavy metal SOAP client
https://bugzilla.redhat.com/show_bug.cgi?id=1121119
Jun Aruga jaruga@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jaruga@redhat.com
--- Comment #1 from Jun Aruga jaruga@redhat.com --- Hi, Steve. Let me review it.
- Mock build was failed.
$ mock -r fedora-rawhide-x86_64 rubygem-gyoku-1.1.1-1.fc20.src.rpm ... Error: nothing provides rubygem(tins) >= 1.6.0 needed by rubygem-coveralls-0.8.10-1.fc24.noarch ...
The srpm file requires rubygem-coveralls in the spec file.
BuildRequires: rubygem-coveralls
But it is not good that the package requires coverage modules such as rubygem-coveralls, simplecov, also bundler. So, you can remove below lines in the spec file.
Requires: rubygem(builder) BuildRequires: rubygem(coveralls) BuildRequires: rubygem(simplecov)
And replace spec/spec_helper.rb by the using sed command in %check section, not to run coverage.
See other package's spec files for reference:
http://pkgs.fedoraproject.org/cgit/rpms/rubygem-timers.git/tree/rubygem-time...
http://pkgs.fedoraproject.org/cgit/rpms/rubygem-web-console.git/tree/rubygem... [1]
- Unfortunately after your review request, the time has passed. The gyoku latest version became 1.3.1 from 1.1.1. You should update the version in rpm.
[1] To check other spec files, I used below way.
You can see rpm-specs-latest.tar.xz file at http://pkgs.fedoraproject.org/repo This file includes all the latest spec files.
Downloaded the file. Then to find the spec files that are using coverage module, using "sed" to replace, and new.
tar xf rpm-specs-latest.tar.xz cd rpm-specs find . -name "rubygem-*" | xargs grep -l "sed -i" \ | xargs grep -l "cov" \ | xargs grep -A 10 "^%changelog"
https://bugzilla.redhat.com/show_bug.cgi?id=1121119
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com
--- Comment #2 from Vít Ondruch vondruch@redhat.com --- (In reply to Jun Aruga from comment #1)
Hi, Steve. Let me review it.
Mock build was failed.
$ mock -r fedora-rawhide-x86_64 rubygem-gyoku-1.1.1-1.fc20.src.rpm ... Error: nothing provides rubygem(tins) >= 1.6.0 needed by
rubygem-coveralls-0.8.10-1.fc24.noarch ...
This is actually issue of Coveralls. But it seems that the yesterdays build (http://koji.fedoraproject.org/koji/buildinfo?buildID=743095) should fix that issue.
Also, looking at the .spec file, I'll note here a few random tips:
Use the %license macro, drop the unnecessary conditionals, use a wildcard for exclusion of the dot files.
https://bugzilla.redhat.com/show_bug.cgi?id=1121119
Steve Traylen steve.traylen@cern.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed| |2017-05-31 05:20:40
--- Comment #3 from Steve Traylen steve.traylen@cern.ch --- So old, can't remember by why I wanted it. Apologies for the lack of response.
package-review@lists.fedoraproject.org