https://bugzilla.redhat.com/show_bug.cgi?id=2271315
Bug ID: 2271315 Summary: Review Request: mod_mapcache - Caching server for WMS layers Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: neil@shrug.pw QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://neil.fedorapeople.org/reviews/mod_mapcache/mod_mapcache.spec SRPM URL: https://neil.fedorapeople.org/reviews/mod_mapcache/mod_mapcache-1.14.0-1.fc3...
Description: MapCache is a server that implements tile caching to speed up access to WMS layers. The primary objectives are to be fast and easily deployable, while offering the essential features (and more!) expected from a tile caching solution. This is the MapCache module for the Apache web server implementing OGC web services. An alternative mapcache FastCGI program is available in libmapcache-fcgi.
https://bugzilla.redhat.com/show_bug.cgi?id=2271315
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://mapserver.org/trunk/ | |en/mapcache/
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7208463 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- License file LICENSE.md is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2271315
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org Flags| |fedora-review? CC| |benson_muite@emailplus.org
https://bugzilla.redhat.com/show_bug.cgi?id=2271315
--- Comment #4 from Neil Hanlon neil@shrug.pw --- Spec URL: https://neil.fedorapeople.org/reviews/mod_mapcache/mod_mapcache.spec SRPM URL: https://neil.fedorapeople.org/reviews/mod_mapcache/mod_mapcache-1.14.0-1.fc3...
- Include mapcache.xml - split into subpackages following debian
https://bugzilla.redhat.com/show_bug.cgi?id=2271315
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2023537 --> https://bugzilla.redhat.com/attachment.cgi?id=2023537&action=edit The .spec file difference from Copr build 7208463 to 7212533
https://bugzilla.redhat.com/show_bug.cgi?id=2271315
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7212533 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2271315
--- Comment #7 from Benson Muite benson_muite@emailplus.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License", "BSD 3-Clause License", "*No copyright* MIT License". 130 files have unknown license. Detailed output of licensecheck in /home/fedora/2271315-mod_mapcache/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/httpd, /usr/share/mapcache, /usr/lib64/httpd/modules [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/mapcache [x]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1306 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libmapcache , libmapcache-devel , libmapcache-fcgi , libmapcache-tools [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: mod_mapcache-1.14.0-1.fc41.aarch64.rpm libmapcache-1.14.0-1.fc41.aarch64.rpm libmapcache-devel-1.14.0-1.fc41.aarch64.rpm libmapcache-doc-1.14.0-1.fc41.noarch.rpm libmapcache-fcgi-1.14.0-1.fc41.aarch64.rpm libmapcache-tools-1.14.0-1.fc41.aarch64.rpm mod_mapcache-debuginfo-1.14.0-1.fc41.aarch64.rpm mod_mapcache-debugsource-1.14.0-1.fc41.aarch64.rpm mod_mapcache-1.14.0-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpdj6922qa')] checks: 32, packages: 9
libmapcache.aarch64: E: useless-provides group(mapcache) libmapcache-fcgi.aarch64: W: summary-not-capitalized fcgi implementation for mapcache libmapcache-tools.aarch64: W: summary-not-capitalized tools for mapcache libmapcache.aarch64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') libmapcache-devel.aarch64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') libmapcache-doc.noarch: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') libmapcache-fcgi.aarch64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') libmapcache-tools.aarch64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') mod_mapcache.aarch64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') mod_mapcache.aarch64: E: spelling-error ('libmapcache', '%description -l en_US libmapcache -> cachepot') mod_mapcache.aarch64: E: spelling-error ('fcgi', '%description -l en_US fcgi -> CGI') mod_mapcache.src: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') mod_mapcache.src: E: spelling-error ('libmapcache', '%description -l en_US libmapcache -> cachepot') mod_mapcache.src: E: spelling-error ('fcgi', '%description -l en_US fcgi -> CGI') libmapcache-fcgi.aarch64: W: no-manual-page-for-binary mapcache.fcgi libmapcache-tools.aarch64: W: no-manual-page-for-binary mapcache_detail libmapcache-tools.aarch64: W: no-manual-page-for-binary mapcache_seed libmapcache.aarch64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-devel.aarch64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-devel.aarch64: E: description-line-too-long Development files for mapcache; these files are needed when building binary packages libmapcache-doc.noarch: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-fcgi.aarch64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-tools.aarch64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. mod_mapcache.aarch64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. mod_mapcache.src: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-doc.noarch: E: bad-manual-page-folder /usr/share/man/man1/mapcache_detail.1.xml.gz expected folder: manxml libmapcache-doc.noarch: E: bad-manual-page-folder /usr/share/man/man1/mapcache_seed.1.xml.gz expected folder: manxml 9 packages and 0 specfiles checked; 22 errors, 5 warnings, 40 filtered, 22 badness; has taken 1.7 s
Rpmlint (debuginfo) ------------------- Checking: mod_mapcache-debuginfo-1.14.0-1.fc41.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqxpeslbt')] checks: 32, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 9 filtered, 0 badness; has taken 0.2 s
Rpmlint (installed packages) ---------------------------- /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 8
libmapcache.aarch64: E: useless-provides group(mapcache) mod_mapcache.aarch64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_hook_handler (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.aarch64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_set_content_type (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.aarch64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_hook_post_config (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.aarch64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_get_brigade (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.aarch64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_meets_conditions (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.aarch64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_hook_child_init (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.aarch64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_log_error_(/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.aarch64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_update_mtime (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.aarch64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_construct_url (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.aarch64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_add_version_component (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.aarch64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_hook_fixups (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.aarch64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_hook_quick_handler (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.aarch64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_set_content_length (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.aarch64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_log_rerror_ (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.aarch64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_rwrite (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.aarch64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_check_cmd_context (/usr/lib64/httpd/modules/mod_mapcache.so) libmapcache-tools.aarch64: W: summary-not-capitalized tools for mapcache libmapcache-fcgi.aarch64: W: summary-not-capitalized fcgi implementation for mapcache libmapcache-tools.aarch64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') mod_mapcache.aarch64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') mod_mapcache.aarch64: E: spelling-error ('libmapcache', '%description -l en_US libmapcache -> cachepot') mod_mapcache.aarch64: E: spelling-error ('fcgi', '%description -l en_US fcgi -> CGI') libmapcache.aarch64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') libmapcache-doc.noarch: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') libmapcache-fcgi.aarch64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') libmapcache-devel.aarch64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') libmapcache-tools.aarch64: W: no-manual-page-for-binary mapcache_detail libmapcache-tools.aarch64: W: no-manual-page-for-binary mapcache_seed libmapcache-fcgi.aarch64: W: no-manual-page-for-binary mapcache.fcgi libmapcache-tools.aarch64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. mod_mapcache.aarch64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache.aarch64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-doc.noarch: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-fcgi.aarch64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-devel.aarch64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-devel.aarch64: E: description-line-too-long Development files for mapcache; these files are needed when building binary packages libmapcache-doc.noarch: E: bad-manual-page-folder /usr/share/man/man1/mapcache_detail.1.xml.gz expected folder: manxml libmapcache-doc.noarch: E: bad-manual-page-folder /usr/share/man/man1/mapcache_seed.1.xml.gz expected folder: manxml 8 packages and 0 specfiles checked; 18 errors, 21 warnings, 38 filtered, 18 badness; has taken 2.0 s
Unversioned so-files -------------------- mod_mapcache: /usr/lib64/httpd/modules/mod_mapcache.so
Source checksums ---------------- https://salsa.debian.org/debian-gis-team/mapcache/-/raw/master/debian/man/ma... : CHECKSUM(SHA256) this package : 616aaa9f1a75fea316045e3dae9af8daafbf879253a60f66de5ea998b1cc7f2a CHECKSUM(SHA256) upstream package : 616aaa9f1a75fea316045e3dae9af8daafbf879253a60f66de5ea998b1cc7f2a https://salsa.debian.org/debian-gis-team/mapcache/-/raw/master/debian/man/ma... : CHECKSUM(SHA256) this package : a073751c2bef726525974da3e36ad37e2c21ca534112a6d32b97f6414d183f66 CHECKSUM(SHA256) upstream package : a073751c2bef726525974da3e36ad37e2c21ca534112a6d32b97f6414d183f66 https://github.com/MapServer/mapcache/releases/download/rel-1-14-0/mapcache-... : CHECKSUM(SHA256) this package : a718676b8825edf949392ba93b12f3acc78f88cde63a9a1ca7508fdff3eb9efb CHECKSUM(SHA256) upstream package : a718676b8825edf949392ba93b12f3acc78f88cde63a9a1ca7508fdff3eb9efb
Requires -------- mod_mapcache (rpmlib, GLIBC filtered): /bin/sh config(mod_mapcache) httpd ld-linux-aarch64.so.1()(64bit) libapr-1.so.0()(64bit) libaprutil-1.so.0()(64bit) libc.so.6()(64bit) libmapcache(aarch-64) libmapcache.so.1()(64bit) rtld(GNU_HASH)
libmapcache (rpmlib, GLIBC filtered): ld-linux-aarch64.so.1()(64bit) libapr-1.so.0()(64bit) libaprutil-1.so.0()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libgdal.so.34()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libpixman-1.so.0()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libsqlite3.so.0()(64bit) rtld(GNU_HASH)
libmapcache-devel (rpmlib, GLIBC filtered): libmapcache.so.1()(64bit)
libmapcache-doc (rpmlib, GLIBC filtered):
libmapcache-fcgi (rpmlib, GLIBC filtered): ld-linux-aarch64.so.1()(64bit) libapr-1.so.0()(64bit) libaprutil-1.so.0()(64bit) libc.so.6()(64bit) libfcgi.so.0()(64bit) libmapcache(aarch-64) libmapcache.so.1()(64bit) rtld(GNU_HASH)
libmapcache-tools (rpmlib, GLIBC filtered): ld-linux-aarch64.so.1()(64bit) libapr-1.so.0()(64bit) libaprutil-1.so.0()(64bit) libc.so.6()(64bit) libgdal.so.34()(64bit) libgeos_c.so.1()(64bit) libm.so.6()(64bit) libmapcache.so.1()(64bit) libsqlite3.so.0()(64bit) rtld(GNU_HASH)
mod_mapcache-debuginfo (rpmlib, GLIBC filtered):
mod_mapcache-debugsource (rpmlib, GLIBC filtered):
Provides -------- mod_mapcache: config(mod_mapcache) mod_mapcache mod_mapcache(aarch-64)
libmapcache: group(mapcache) libmapcache libmapcache(aarch-64) libmapcache.so.1()(64bit) user(mapcache)
libmapcache-devel: libmapcache-devel libmapcache-devel(aarch-64)
libmapcache-doc: libmapcache-doc
libmapcache-fcgi: libmapcache-fcgi libmapcache-fcgi(aarch-64)
libmapcache-tools: libmapcache-tools libmapcache-tools(aarch-64)
mod_mapcache-debuginfo: debuginfo(build-id) mod_mapcache-debuginfo mod_mapcache-debuginfo(aarch-64)
mod_mapcache-debugsource: mod_mapcache-debugsource mod_mapcache-debugsource(aarch-64)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2271315 Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Java, Python, PHP, SugarActivity, Ocaml, Haskell, fonts, Perl, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Comments: a) Do copies of INSTALL.md README.md need to be in both the main and doc subpackages? b) Should lmdb and libdb be included as a dependency: https://packages.fedoraproject.org/pkgs/lmdb/lmdb/ https://packages.fedoraproject.org/pkgs/libdb/libdb/ See: https://mapserver.org/mapcache/install.html c) Can tests be run: https://github.com/MapServer/mapcache/tree/main/tests d) In the files section add: %dir %{_datadir}/mapcache e) Two files are under BSD-3-Clause: BSD 3-Clause License -------------------- mapcache-1.14.0/lib/hmac-sha.c mapcache-1.14.0/lib/strptime.c
https://bugzilla.redhat.com/show_bug.cgi?id=2271315
--- Comment #8 from Neil Hanlon neil@shrug.pw --- Thank you for the review! I owe you at least one already, so, I will work on some for you in the next week.
a) Do copies of INSTALL.md README.md need to be in both the main and doc subpackages?
Probably not. Should they be in the doc package or the main subpackage?
b) Should lmdb and libdb be included as a dependency: https://packages.fedoraproject.org/pkgs/lmdb/lmdb/ https://packages.fedoraproject.org/pkgs/libdb/libdb/ See: https://mapserver.org/mapcache/install.html
I've asked the original spec author that I've been working with, but we don't believe they are hard dependencies. Perhaps I can add them as Suggests?
c) Can tests be run: https://github.com/MapServer/mapcache/tree/main/tests
I looked into these a bit but they appear to require installing and running an HTTPD server to make requests to it. I wasn't sure if these sort of tests were appropriate for rpm %check, or if they should be implemented as Zuul or tmt tests instead?
d) In the files section add: %dir %{_datadir}/mapcache
Done
e) Two files are under BSD-3-Clause: BSD 3-Clause License -------------------- mapcache-1.14.0/lib/hmac-sha.c mapcache-1.14.0/lib/strptime.c
Ack. I've modified the license to MIT AND BSD-3-Clause.
https://bugzilla.redhat.com/show_bug.cgi?id=2271315
--- Comment #9 from Neil Hanlon neil@shrug.pw --- Spec URL: https://neil.fedorapeople.org/reviews/mod_mapcache/mod_mapcache.spec SRPM URL: https://neil.fedorapeople.org/reviews/mod_mapcache/mod_mapcache-1.14.0-1.fc3...
- add mapcache header files - add Requires on libmapcache to mapserver
https://bugzilla.redhat.com/show_bug.cgi?id=2271315
--- Comment #10 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2023693 --> https://bugzilla.redhat.com/attachment.cgi?id=2023693&action=edit The .spec file difference from Copr build 7212533 to 7217463
https://bugzilla.redhat.com/show_bug.cgi?id=2271315
--- Comment #11 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7217463 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2271315
--- Comment #12 from Benson Muite benson_muite@emailplus.org --- Comments: a) lmdb and libdb enable extra functionality, `suggests` would not give this as the functionality needs to be built when compiling. It is ok not to have them, but may lead to performance improvements in some situations.
b) Tests seem like they would need more careful setup. They are not a must, but if there is some way of check ing basic functionality, that would be great.
c) Fedora-review errors: libmapcache.aarch64: E: useless-provides group(mapcache) libmapcache-fcgi.aarch64: W: summary-not-capitalized fcgi implementation for mapcache libmapcache-tools.aarch64: W: summary-not-capitalized tools for mapcache l libmapcache-devel.aarch64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-devel.aarch64: E: description-line-too-long Development files for mapcache; these files are needed when building binary packages libmapcache-doc.noarch: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-fcgi.aarch64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-tools.aarch64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. mod_mapcache.aarch64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. mod_mapcache.src: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-doc.noarch: E: bad-manual-page-folder /usr/share/man/man1/mapcache_detail.1.xml.gz expected folder: manxml libmapcache-doc.noarch: E: bad-manual-page-folder /usr/share/man/man1/mapcache_seed.1.xml.gz expected folder: manxml
d) Can probably remove Group: Development/Tools from the spec file.
https://bugzilla.redhat.com/show_bug.cgi?id=2271315
--- Comment #13 from Neil Hanlon neil@shrug.pw --- Spec URL: https://neil.fedorapeople.org/reviews/mod_mapcache/mod_mapcache.spec SRPM URL: https://neil.fedorapeople.org/reviews/mod_mapcache/mod_mapcache-1.14.0-1.fc3...
- add mapcache header files - add Requires on libmapcache to mapserver
https://bugzilla.redhat.com/show_bug.cgi?id=2271315
--- Comment #14 from Neil Hanlon neil@shrug.pw --- Hi Benson,
Are there any additional comments on this review, or is it ok to proceed?
Neil
https://bugzilla.redhat.com/show_bug.cgi?id=2271315
Neil Hanlon neil@shrug.pw changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(benson_muite@emai | |lplus.org)
--- Comment #15 from Neil Hanlon neil@shrug.pw --- Hi Benson, sorry for the needinfo ping:
The person I'm bringing this package into Fedora/EPEL for is anxious to have it available, and to hopefully introduce further map-related packages to Fedora. Will you be able to complete this review?
https://bugzilla.redhat.com/show_bug.cgi?id=2271315
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) |
--- Comment #16 from Benson Muite benson_muite@emailplus.org --- Sorry for the delay, will complete the review this week.
https://bugzilla.redhat.com/show_bug.cgi?id=2271315
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #17 from Benson Muite benson_muite@emailplus.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package must not depend on deprecated() packages. Note: libdb-devel is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/
===== MUST items =====
C/C++: [ ]: Package does not contain kernel modules. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs.
Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License", "BSD 3-Clause License", "*No copyright* MIT License". 130 files have unknown license. Detailed output of licensecheck in /home/fedora/2271315-mod_mapcache/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libmapcache , libmapcache-devel , libmapcache-fcgi , libmapcache-tools [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: mod_mapcache-1.14.0-1.fc41.x86_64.rpm libmapcache-1.14.0-1.fc41.x86_64.rpm libmapcache-devel-1.14.0-1.fc41.x86_64.rpm libmapcache-doc-1.14.0-1.fc41.noarch.rpm libmapcache-fcgi-1.14.0-1.fc41.x86_64.rpm libmapcache-tools-1.14.0-1.fc41.x86_64.rpm mod_mapcache-debuginfo-1.14.0-1.fc41.x86_64.rpm mod_mapcache-debugsource-1.14.0-1.fc41.x86_64.rpm mod_mapcache-1.14.0-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpwggv150r')] checks: 32, packages: 9
libmapcache.x86_64: E: useless-provides group(mapcache) libmapcache.x86_64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') libmapcache-devel.x86_64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') libmapcache-doc.noarch: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') libmapcache-fcgi.x86_64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') libmapcache-tools.x86_64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') mod_mapcache.src: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') mod_mapcache.src: E: spelling-error ('libmapcache', '%description -l en_US libmapcache -> cachepot') mod_mapcache.src: E: spelling-error ('fcgi', '%description -l en_US fcgi -> CGI') mod_mapcache.x86_64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') mod_mapcache.x86_64: E: spelling-error ('libmapcache', '%description -l en_US libmapcache -> cachepot') mod_mapcache.x86_64: E: spelling-error ('fcgi', '%description -l en_US fcgi -> CGI') libmapcache-fcgi.x86_64: W: no-manual-page-for-binary mapcache.fcgi libmapcache-tools.x86_64: W: no-manual-page-for-binary mapcache_detail libmapcache-tools.x86_64: W: no-manual-page-for-binary mapcache_seed mod_mapcache.x86_64: W: no-documentation libmapcache.x86_64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-devel.x86_64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-devel.x86_64: E: description-line-too-long Development files for mapcache; these files are needed when building binary packages libmapcache-doc.noarch: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-fcgi.x86_64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-tools.x86_64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. mod_mapcache.src: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. mod_mapcache.x86_64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. 9 packages and 0 specfiles checked; 20 errors, 4 warnings, 48 filtered, 20 badness; has taken 1.8 s
Rpmlint (debuginfo) ------------------- Checking: mod_mapcache-debuginfo-1.14.0-1.fc41.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpepazrkto')] checks: 32, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 10 filtered, 0 badness; has taken 0.2 s
Rpmlint (installed packages) ---------------------------- /bin/sh: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8): No such file or directory ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 8
libmapcache.x86_64: E: useless-provides group(mapcache) mod_mapcache.x86_64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_hook_handler (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.x86_64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_set_content_type (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.x86_64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_hook_post_config (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.x86_64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_get_brigade (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.x86_64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_meets_conditions (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.x86_64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_hook_child_init (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.x86_64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_log_error_ (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.x86_64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_update_mtime (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.x86_64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_construct_url (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.x86_64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_add_version_component (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.x86_64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_hook_fixups (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.x86_64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_hook_quick_handler (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.x86_64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_set_content_length (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.x86_64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_log_rerror_ (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.x86_64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_rwrite (/usr/lib64/httpd/modules/mod_mapcache.so) mod_mapcache.x86_64: W: undefined-non-weak-symbol /usr/lib64/httpd/modules/mod_mapcache.so ap_check_cmd_context (/usr/lib64/httpd/modules/mod_mapcache.so) libmapcache-devel.x86_64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') mod_mapcache.x86_64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') mod_mapcache.x86_64: E: spelling-error ('libmapcache', '%description -l en_US libmapcache -> cachepot') mod_mapcache.x86_64: E: spelling-error ('fcgi', '%description -l en_US fcgi -> CGI') libmapcache-tools.x86_64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') libmapcache.x86_64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') libmapcache-fcgi.x86_64: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') libmapcache-doc.noarch: E: spelling-error ('deployable', '%description -l en_US deployable -> deplorable, deploy able, deploy-able') libmapcache-tools.x86_64: W: no-manual-page-for-binary mapcache_detail libmapcache-tools.x86_64: W: no-manual-page-for-binary mapcache_seed libmapcache-fcgi.x86_64: W: no-manual-page-for-binary mapcache.fcgi mod_mapcache.x86_64: W: no-documentation libmapcache-devel.x86_64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-devel.x86_64: E: description-line-too-long Development files for mapcache; these files are needed when building binary packages mod_mapcache.x86_64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-tools.x86_64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache.x86_64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-fcgi.x86_64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-doc.noarch: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. 8 packages and 0 specfiles checked; 16 errors, 20 warnings, 44 filtered, 16 badness; has taken 2.2 s
Unversioned so-files -------------------- mod_mapcache: /usr/lib64/httpd/modules/mod_mapcache.so
Source checksums ---------------- https://salsa.debian.org/debian-gis-team/mapcache/-/raw/master/debian/man/ma... : CHECKSUM(SHA256) this package : 616aaa9f1a75fea316045e3dae9af8daafbf879253a60f66de5ea998b1cc7f2a CHECKSUM(SHA256) upstream package : 616aaa9f1a75fea316045e3dae9af8daafbf879253a60f66de5ea998b1cc7f2a https://salsa.debian.org/debian-gis-team/mapcache/-/raw/master/debian/man/ma... : CHECKSUM(SHA256) this package : a073751c2bef726525974da3e36ad37e2c21ca534112a6d32b97f6414d183f66 CHECKSUM(SHA256) upstream package : a073751c2bef726525974da3e36ad37e2c21ca534112a6d32b97f6414d183f66 https://github.com/MapServer/mapcache/releases/download/rel-1-14-0/mapcache-... : CHECKSUM(SHA256) this package : a718676b8825edf949392ba93b12f3acc78f88cde63a9a1ca7508fdff3eb9efb CHECKSUM(SHA256) upstream package : a718676b8825edf949392ba93b12f3acc78f88cde63a9a1ca7508fdff3eb9efb
Requires -------- mod_mapcache (rpmlib, GLIBC filtered): /bin/sh config(mod_mapcache) httpd libapr-1.so.0()(64bit) libaprutil-1.so.0()(64bit) libc.so.6()(64bit) libmapcache(x86-64) libmapcache.so.1()(64bit) rtld(GNU_HASH)
libmapcache (rpmlib, GLIBC filtered): libapr-1.so.0()(64bit) libaprutil-1.so.0()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libgdal.so.35()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libm.so.6()(64bit) libpixman-1.so.0()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libsqlite3.so.0()(64bit) mapserver(x86-64) rtld(GNU_HASH)
libmapcache-devel (rpmlib, GLIBC filtered): libmapcache.so.1()(64bit)
libmapcache-doc (rpmlib, GLIBC filtered):
libmapcache-fcgi (rpmlib, GLIBC filtered): libapr-1.so.0()(64bit) libaprutil-1.so.0()(64bit) libc.so.6()(64bit) libfcgi.so.0()(64bit) libmapcache(x86-64) libmapcache.so.1()(64bit) rtld(GNU_HASH)
libmapcache-tools (rpmlib, GLIBC filtered): libapr-1.so.0()(64bit) libaprutil-1.so.0()(64bit) libc.so.6()(64bit) libgdal.so.35()(64bit) libgeos_c.so.1()(64bit) libm.so.6()(64bit) libmapcache.so.1()(64bit) libsqlite3.so.0()(64bit) rtld(GNU_HASH)
mod_mapcache-debuginfo (rpmlib, GLIBC filtered):
mod_mapcache-debugsource (rpmlib, GLIBC filtered):
Provides -------- mod_mapcache: config(mod_mapcache) mod_mapcache mod_mapcache(x86-64)
libmapcache: group(mapcache) libmapcache libmapcache(x86-64) libmapcache.so.1()(64bit) user(mapcache)
libmapcache-devel: libmapcache-devel libmapcache-devel(x86-64)
libmapcache-doc: libmapcache-doc
libmapcache-fcgi: libmapcache-fcgi libmapcache-fcgi(x86-64)
libmapcache-tools: libmapcache-tools libmapcache-tools(x86-64)
mod_mapcache-debuginfo: debuginfo(build-id) mod_mapcache-debuginfo mod_mapcache-debuginfo(x86-64)
mod_mapcache-debugsource: mod_mapcache-debugsource mod_mapcache-debugsource(x86-64)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2271315 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Haskell, PHP, Perl, Python, fonts, R, Java, Ocaml, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
comments;: a) libdb seems to have been deprecated, so remove it - sorry for earlier suggesting its inclusion. b) please shorten description lines: libmapcache-devel.x86_64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-devel.x86_64: E: description-line-too-long Development files for mapcache; these files are needed when building binary packages mod_mapcache.x86_64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-tools.x86_64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache.x86_64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-fcgi.x86_64: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. libmapcache-doc.noarch: E: description-line-too-long MapCache is a server that implements tile caching to speed up access to WMS layers. c) URL https://mapserver.org/trunk/en/mapcache/ seems to not be correctly configured perhaps use https://mapserver.org/mapcache/ d) Approved, please make necessary changes before importing.
package-review@lists.fedoraproject.org