Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492715
--- Comment #18 from Paulo Roma Cavalcanti <promac(a)gmail.com> 2009-05-29 06:29:12
EDT ---
(In reply to comment #17)
OK, I assigned this for review, but we have here some issues in spec
file:
1. Please purify spec file. I mean that you drop your macro definitions for
snapshot and ffmpeg. ffmpeg must be droped out from spec file!
I will do it. I just kept them for now so I can fully test the
resulting rpm.
2. This version is snapshot. Can you expect stable release soon?
I think so. It was promised sometime ago, but maybe the author
is trying to provide a better pulse support (I suggested him to talk to
Lennard).
3. I think that you do not need these BR-s:
-chrpath (RPATHS resolved by %cmake_kde4 macro
-gcc-c++
-qt-devel
Try to build without them
They are not needed. I just used qt-devel to specify the minimum version.
4. Please, try to use BuildRoot in form of this:
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
-n)
Done. I should have missed the %{version} in a cut-and-paste action.
5. Please use kde4 macros for cmake, dirs, (I'll attach
kdenlive.spec as
example)
Done.
6. .desktop file:
Why you wrote .desktop file? Isn't a author's job?
I did not find any desktop entry, so I wrote one.
7. Why you copy icons from /icons dir to /pixmaps?
Not really necessary. Removed.
8. %defattr must be %defattr(-,root,root,-)
Done.
9. {_datadir}/icons/hicolor/*/*/* you can write on this way:
{_datadir}/icons/hicolor/*
Would I not have been claiming ownership of the intermediate directories this
way?
10.Please, try to build this package with Koji (or local Mock) for
F10 and F11
branches. It must be successfully!
It is building just fine.
SPEC:
http://orion.lcg.ufrj.br/RPMS/SPECS/kradio4.spec
SRPM:
http://orion.lcg.ufrj.br/RPMS/src/kradio4-4.0.0-0.10.r883.20090514.fc10.s...
Thanks.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.