https://bugzilla.redhat.com/show_bug.cgi?id=1990222
Jakub Kadlčík <jkadlcik(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Doc Type|--- |If docs needed, set a value
CC| |jkadlcik(a)redhat.com
--- Comment #2 from Jakub Kadlčík <jkadlcik(a)redhat.com> ---
# Created by pyp2rpm-3.3.7
I would drop this line.
%global forgeurl
https://github.com/internetarchive/surt
%global commit 6934c321b3e2f66af9c001d882475949f00570c5
I understand why you are not using `Source0: %{pypi_source}` and using
Source0 from github instead of PyPI, but pointing to commit is not
ideal. If you are involved in the upstream project, can you please
create a git tag for 0.3.1 version? Otherwise, I would recommend asking
upstream via issue tracker or some other way of communication to
create the tag for you. Only after being rejected or ignored, I would
proceed with using commit instead of tag in the spec file.
%global common_description %{expand:
Sort-friendly URI Reordering Transform (SURT) python package.}
Please do not duplicate the summary line here and rather elaborate a
bit more. There is a nice usage example in the project README, I
would add it to the package description for sure :-)
# Remove bundled egg-info
rm -rf %{pypi_name}.egg-info
I think you can safely drop this
# Remove unneeded shebang
Good catch. Please consider creating an upstream issue or pull request
and linking it here in the specfile, so we can eventually get rid of
this workaround
BuildRequires: sed
I cannot find the proper documentation right now, but I think this
dependency can be dropped because it is in the minimal buildroot.
Overall, I like the package, good job, Davide.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1990222