https://bugzilla.redhat.com/show_bug.cgi?id=2036135
--- Comment #4 from František Zatloukal <fzatlouk(a)redhat.com> ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #2)
Initial review:
> BuildRequires: g++
Shouldn't this be: gcc-g++ ?
Fixed
> BuildRequires: intel-gmmlib
> BuildRequires: intel-gmmlib-devel
> BuildRequires: libva-devel
> BuildRequires: intel-igc
> BuildRequires: intel-igc-devel
I'd expect the -devel packages to have Requires: on their non-devel parts,
so are the non-devel ones (intel-gmmlib and intel-igc) strictly necessary?
Fixed
> Version: 21.50.21939
...
> -DNEO_OCL_VERSION_MAJOR=21 \
> -DNEO_OCL_VERSION_MINOR=50 \
> -DNEO_VERSION_BUILD=21939 \
This begs for automation, otherwise it's prone to missed updates in both
places.
Either construct Version: from these three components or extract the right
component from Version when passing to cmake.
Fixed
> -DCMAKE_BUILD_TYPE=Release \
> -DBUILD_SHARED_LIBS:BOOL=OFF \
> -DCMAKE_BUILD_TYPE=Release \
You're passing CMAKE_BUOLD_TYPE twice.
Fixed
> %if 0%{?__isa_bits} == 64
> -DCMAKE_INSTALL_LIBDIR=lib64 \
> %else
> -DCMAKE_INSTALL_LIBDIR=lib \
> %endif
%cmake macro contains this:
-DLIB_INSTALL_DIR:PATH=/usr/lib64 \
...
%if "lib64" == "lib64"
-DLIB_SUFFIX=64 \
%endif
so the above should not be necessary and if it is, it's a bug in CMakeLists.
Fixed
> -DSKIP_UNIT_TESTS=1 \
How hard would it be to build and run the tests?
Tests are currently failing on multiple places on copy commands, which makes it
seem like they're not maintained like they should be (or it may be caused by
DNEO_DISABLE_BUILTINS_COMPILATION), I'll report upstream.
> %{_libdir}/libocloc.so
Unversioned .so in %{_libdir} is questionable[1]. Please explain why it's OK.
[1]
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
Upstream doesn't version .so files by default. I'll ask about it, shall I go on
with plain mv & ln ?
> %global optflags %{optflags} -Wno-error=odr
...
> -Wno-dev \
Why are you passing one flag in optflags and another in %cmake? This seems
inconsistent.
Fixed.
Also, bumped the package to the latest tag, fixed gcc12 build.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2036135