https://bugzilla.redhat.com/show_bug.cgi?id=1493787
Bug ID: 1493787 Summary: Review Request: ghc-free - Monads for free Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: quantum.analyst@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://qulogic.fedorapeople.org//ghc-free.spec SRPM URL: http://qulogic.fedorapeople.org//ghc-free-4.12.4-4.git.0.950ee55.fc26.src.rp...
Description: Free monads are useful for many tree-like structures and domain specific languages.
If 'f' is a 'Functor' then the free 'Monad' on 'f' is the type of trees whose nodes are labeled with the constructors of 'f'. The word "free" is used in the sense of "unrestricted" rather than "zero-cost": 'Free f' makes no constraining assumptions beyond those given by 'f' and the definition of 'Monad'. As used here it is a standard term from the mathematical theory of adjoint functors.
Cofree comonads are dual to free monads. They provide convenient ways to talk about branching streams and rose-trees, and can be used to annotate syntax trees. The cofree comonad can be seen as a stream parameterized by a 'Functor' that controls its branching factor.
More information on free monads, including examples, can be found in the following blog posts: http://comonad.com/reader/2008/monads-for-free/ http://comonad.com/reader/2011/free-monads-for-less/.
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
--- Comment #1 from Elliott Sales de Andrade quantum.analyst@gmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=21991431
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1485493, 1492357, 1236364 | |(ghc-comonad), 1492890, | |1492893
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1236364 [Bug 1236364] Review Request: ghc-comonad - Comonads https://bugzilla.redhat.com/show_bug.cgi?id=1485493 [Bug 1485493] Review Request: ghc-base-orphans - Backwards-compatible orphan instances for base https://bugzilla.redhat.com/show_bug.cgi?id=1492357 [Bug 1492357] Review Request: ghc-bifunctors - Bifunctors https://bugzilla.redhat.com/show_bug.cgi?id=1492890 [Bug 1492890] Review Request: ghc-profunctors - Profunctors https://bugzilla.redhat.com/show_bug.cgi?id=1492893 [Bug 1492893] Review Request: ghc-semigroupoids - Semigroupoids: Category sans id
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
--- Comment #2 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Probably get asked to split out the docs since they're >1M.
Spec URL: https://qulogic.fedorapeople.org/git-annex/ghc-free.spec SRPM URL: https://qulogic.fedorapeople.org/git-annex/ghc-free-4.12.4-5.git.0.2203773.f...
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21992467
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- All ok, package accepted.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (unspecified)", "BSD (2 clause)", "Unknown or generated". 22 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/ghc-free/review-ghc-free/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/ghc/html, /usr/share/doc/ghc/html/libraries, /usr/share/doc/ghc [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 92160 bytes in 15 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ghc- free-devel-doc [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: ghc-free-4.12.4-5.fc27.x86_64.rpm ghc-free-devel-4.12.4-5.fc27.x86_64.rpm ghc-free-devel-doc-4.12.4-5.fc27.noarch.rpm ghc-free-4.12.4-5.fc27.src.rpm ghc-free.x86_64: W: spelling-error Summary(en_US) Monads -> Gonads, Mona's, Mon ads ghc-free.x86_64: W: spelling-error %description -l en_US monads -> nomads, gonads ghc-free.x86_64: W: spelling-error %description -l en_US adjoint -> adjoin, adjoins, ad joint ghc-free.x86_64: W: spelling-error %description -l en_US functors -> functions ghc-free.x86_64: W: spelling-error %description -l en_US Cofree -> Co free, Co-free, Coffee ghc-free.x86_64: W: spelling-error %description -l en_US comonads -> commands ghc-free.x86_64: W: spelling-error %description -l en_US cofree -> coffee, co free, co-free ghc-free.x86_64: W: spelling-error %description -l en_US comonad -> Monaco ghc-free.x86_64: W: spelling-error %description -l en_US parameterized -> parameter ghc-free.x86_64: W: spelling-error %description -l en_US http -> HTTP ghc-free.x86_64: W: no-documentation ghc-free.src: W: spelling-error Summary(en_US) Monads -> Gonads, Mona's, Mon ads ghc-free.src: W: spelling-error %description -l en_US monads -> nomads, gonads ghc-free.src: W: spelling-error %description -l en_US adjoint -> adjoin, adjoins, ad joint ghc-free.src: W: spelling-error %description -l en_US functors -> functions ghc-free.src: W: spelling-error %description -l en_US Cofree -> Co free, Co-free, Coffee ghc-free.src: W: spelling-error %description -l en_US comonads -> commands ghc-free.src: W: spelling-error %description -l en_US cofree -> coffee, co free, co-free ghc-free.src: W: spelling-error %description -l en_US comonad -> Monaco ghc-free.src: W: spelling-error %description -l en_US parameterized -> parameter ghc-free.src: W: spelling-error %description -l en_US http -> HTTP 4 packages and 0 specfiles checked; 0 errors, 21 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
--- Comment #4 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-free
https://bugzilla.redhat.com/show_bug.cgi?id=1493787 Bug 1493787 depends on bug 1236364, which changed state.
Bug 1236364 Summary: Review Request: ghc-comonad - Comonads https://bugzilla.redhat.com/show_bug.cgi?id=1236364
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- ghc-http-conduit-2.2.3.2-1.fc27 ghc-http-client-tls-0.3.5.1-1.fc27 ghc-connection-0.2.8-1.fc27 ghc-tls-1.4.0-1.fc27 ghc-x509-validation-1.6.9-1.fc27 ghc-x509-system-1.6.6-1.fc27 ghc-x509-store-1.6.5-1.fc27 ghc-x509-1.7.2-1.fc27 ghc-asn1-parse-0.9.4-3.fc27 ghc-persistent-template-2.5.2-2.fc27 ghc-persistent-sqlite-2.6.2-5.fc27 ghc-free-4.12.4-5.fc27 ghc-esqueleto-2.5.3-2.fc27 ghc-asn1-encoding-0.9.5-1.fc27 ghc-semigroupoids-5.2.1-2.fc27 ghc-profunctors-5.2.1-3.fc27 ghc-persistent-2.7.0-3.fc27 ghc-asn1-types-0.3.2-3.fc27 ghc-bifunctors-5.4.2-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8255647a5f
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- ghc-asn1-encoding-0.9.5-1.fc27, ghc-asn1-parse-0.9.4-3.fc27, ghc-asn1-types-0.3.2-3.fc27, ghc-bifunctors-5.4.2-2.fc27, ghc-connection-0.2.8-1.fc27, ghc-esqueleto-2.5.3-2.fc27, ghc-free-4.12.4-5.fc27, ghc-http-client-tls-0.3.5.1-1.fc27, ghc-http-conduit-2.2.3.2-1.fc27, ghc-persistent-2.7.0-3.fc27, ghc-persistent-sqlite-2.6.2-5.fc27, ghc-persistent-template-2.5.2-2.fc27, ghc-profunctors-5.2.1-3.fc27, ghc-semigroupoids-5.2.1-2.fc27, ghc-tls-1.4.0-1.fc27, ghc-x509-1.7.2-1.fc27, ghc-x509-store-1.6.5-1.fc27, ghc-x509-system-1.6.6-1.fc27, ghc-x509-validation-1.6.9-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8255647a5f
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- ghc-asn1-encoding-0.9.5-1.fc27 ghc-asn1-parse-0.9.4-3.fc27 ghc-asn1-types-0.3.2-3.fc27 ghc-bifunctors-5.4.2-2.fc27 ghc-connection-0.2.8-1.fc27 ghc-esqueleto-2.5.3-3.fc27 ghc-free-4.12.4-5.fc27 ghc-http-api-data-0.3.7.1-3.fc27 ghc-http-client-tls-0.3.5.1-1.fc27 ghc-http-conduit-2.2.3.2-1.fc27 ghc-persistent-2.7.0-4.fc27 ghc-persistent-sqlite-2.6.2-6.fc27 ghc-persistent-template-2.5.3-1.fc27 ghc-profunctors-5.2.1-3.fc27 ghc-semigroupoids-5.2.1-2.fc27 ghc-tls-1.4.0-1.fc27 ghc-uri-bytestring-0.3.0.1-1.fc27 ghc-x509-1.7.2-1.fc27 ghc-x509-store-1.6.5-1.fc27 ghc-x509-system-1.6.6-1.fc27 ghc-x509-validation-1.6.9-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8255647a5f
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- ghc-asn1-encoding-0.9.5-1.fc27 ghc-asn1-parse-0.9.4-3.fc27 ghc-asn1-types-0.3.2-3.fc27 ghc-bifunctors-5.4.2-2.fc27 ghc-connection-0.2.8-1.fc27 ghc-esqueleto-2.5.3-5.fc27 ghc-free-4.12.4-5.fc27 ghc-http-api-data-0.3.7.1-3.fc27 ghc-http-client-tls-0.3.5.1-1.fc27 ghc-http-conduit-2.2.3.2-1.fc27 ghc-persistent-2.7.1-1.fc27 ghc-persistent-sqlite-2.6.3-1.fc27 ghc-persistent-template-2.5.3-3.fc27 ghc-profunctors-5.2.1-3.fc27 ghc-semigroupoids-5.2.1-2.fc27 ghc-tls-1.4.0-1.fc27 ghc-uri-bytestring-0.3.0.1-1.fc27 ghc-x509-1.7.2-1.fc27 ghc-x509-store-1.6.5-1.fc27 ghc-x509-system-1.6.6-1.fc27 ghc-x509-validation-1.6.9-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-8255647a5f
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- ghc-asn1-encoding-0.9.5-1.fc27, ghc-asn1-parse-0.9.4-3.fc27, ghc-asn1-types-0.3.2-3.fc27, ghc-bifunctors-5.4.2-2.fc27, ghc-connection-0.2.8-1.fc27, ghc-esqueleto-2.5.3-6.fc27, ghc-free-4.12.4-5.fc27, ghc-http-api-data-0.3.7.1-3.fc27, ghc-http-client-tls-0.3.5.1-1.fc27, ghc-http-conduit-2.2.3.2-1.fc27, ghc-persistent-2.7.1-2.fc27, ghc-persistent-sqlite-2.6.3-2.fc27, ghc-persistent-template-2.5.3-4.fc27, ghc-profunctors-5.2.1-3.fc27, ghc-semigroupoids-5.2.1-2.fc27, ghc-tls-1.4.0-1.fc27, ghc-uri-bytestring-0.3.0.1-1.fc27, ghc-x509-1.7.2-1.fc27, ghc-x509-store-1.6.5-1.fc27, ghc-x509-system-1.6.6-1.fc27, ghc-x509-validation-1.6.9-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-8255647a5f
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- ghc-asn1-encoding-0.9.5-1.fc27, ghc-asn1-parse-0.9.4-3.fc27, ghc-asn1-types-0.3.2-3.fc27, ghc-bifunctors-5.4.2-2.fc27, ghc-connection-0.2.8-1.fc27, ghc-esqueleto-2.5.3-6.fc27, ghc-free-4.12.4-5.fc27, ghc-http-api-data-0.3.7.1-3.fc27, ghc-http-client-tls-0.3.5.1-1.fc27, ghc-http-conduit-2.2.3.2-1.fc27, ghc-persistent-2.7.1-2.fc27, ghc-persistent-sqlite-2.6.3-2.fc27, ghc-persistent-template-2.5.3-4.fc27, ghc-profunctors-5.2.1-3.fc27, ghc-semigroupoids-5.2.1-2.fc27, ghc-tls-1.4.0-1.fc27, ghc-uri-bytestring-0.3.0.1-1.fc27, ghc-x509-1.7.2-1.fc27, ghc-x509-store-1.6.5-1.fc27, ghc-x509-system-1.6.6-1.fc27, ghc-x509-validation-1.6.9-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- ghc-free-4.12.4-5.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-3b4276b661
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- ghc-free-4.12.4-5.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-3b4276b661
https://bugzilla.redhat.com/show_bug.cgi?id=1493787 Bug 1493787 depends on bug 1492357, which changed state.
Bug 1492357 Summary: Review Request: ghc-bifunctors - Bifunctors https://bugzilla.redhat.com/show_bug.cgi?id=1492357
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1493787 Bug 1493787 depends on bug 1492890, which changed state.
Bug 1492890 Summary: Review Request: ghc-profunctors - Profunctors https://bugzilla.redhat.com/show_bug.cgi?id=1492890
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1493787 Bug 1493787 depends on bug 1492893, which changed state.
Bug 1492893 Summary: Review Request: ghc-semigroupoids - Semigroupoids: Category sans id https://bugzilla.redhat.com/show_bug.cgi?id=1492893
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1493787
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-12-19 16:33:46
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- ghc-free-4.12.4-5.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org