https://bugzilla.redhat.com/show_bug.cgi?id=967396
Vít Ondruch <vondruch(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |vondruch(a)redhat.com
--- Comment #4 from Vít Ondruch <vondruch(a)redhat.com> ---
(In reply to Anuj More from comment #3)
Hi Josef,
Thanks for reviewing the package.
I am following these guidelines (set by myself after looking at example
specs and talking to vondruch):
https://github.com/execat/Packages/blob/master/rpmspecs/packaging_rules
cp -pr spec/ %{buildroot}%{gem_instdir}
cp -pr spec/ %{buildroot}%{gem_instdir}
I would suggest to replace the %{buildroot} with '.', i.e. wit the current
directory.
Actually, I am not sure why exactly we wrote the guidelines that way, since
unpacking the test suite in %check section would do the same (something like in
activemodel) on one line. We will try to clarify this with FPC.
About Gemfile and Rakefile, vondruch specifically asked me to remove
them
all unless something in the Rakefile really doesn't let package to function
properly.
I agree with jstribny. I am not sure I would said that anytime. I may said,
that some maintainer might have different opinion, but I typically try to keep
everything what comes in gem packaged. If I want to remove something, then I
ask upstream to do that.
[1]
http://pkgs.fedoraproject.org/cgit/rubygem-activemodel.git/tree/rubygem-a...
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=0OgPY2L18v&a=cc_unsubscribe