Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221670
Summary: Review Request: php-pear-Net-UserAgent-Detect - Extract information from an HTTP user agent Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: chris.stone@gmail.com QAContact: fedora-package-review@redhat.com
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Net-UserAgent-Detect.spe... SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Net-UserAgent-Detect-2.2...
Description: The Net_UserAgent object does a number of tests on an HTTP user agent string. The results of these tests are available via methods of the object.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-UserAgent-Detect - Extract information from an HTTP user agent Alias: Net-UserAgent-Detect
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221670
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |Net-UserAgent-Detect
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-UserAgent-Detect - Extract information from an HTTP user agent Alias: Net-UserAgent-Detect
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221670
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |kevin@tummy.com OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From kevin@tummy.com 2007-01-13 00:55 EST ------- OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (PHP) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 87217ac170577bc02cbb99094d1a9a80 Net_UserAgent_Detect-2.2.0.tgz 87217ac170577bc02cbb99094d1a9a80 Net_UserAgent_Detect-2.2.0.tgz.1 c949c65eebc8d2444abe64dd6c6be438f6e218a8 Net_UserAgent_Detect-2.2.0.tgz c949c65eebc8d2444abe64dd6c6be438f6e218a8 Net_UserAgent_Detect-2.2.0.tgz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. See below - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane:
SHOULD Items:
OK - Should build in mock. OK(i386/x86_64) - Should build on all supported archs OK - Should have dist tag OK - Should package latest version
Issues:
1. According to the comments in the source file the license of this package is the php 2.0 license, available as: http://www.php.net/license/2_02.txt The PHP-LICENSE-3.01 included seems to be a newer, diffrent version.
2. This package owns the /usr/share/pear/Net directory. Should it? Or should it require some other package that does?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-UserAgent-Detect - Extract information from an HTTP user agent Alias: Net-UserAgent-Detect
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221670
------- Additional Comments From chris.stone@gmail.com 2007-01-13 17:40 EST ------- Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Net-UserAgent-Detect.spe... SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-Net-UserAgent-Detect-2.2...
%changelog * Sat Jan 13 2007 Christopher Stone chris.stone@gmail.com 2.2.0-2 - Use PHP License version 2.02
- This package owns the
/usr/share/pear/Net directory. Should it? Or should it require some other package that does?
There are many pear packages that share ownership of the same directories. The general rule of thumb in this case is that if the owner of a directory is unclear then the package should own the directory.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-UserAgent-Detect - Extract information from an HTTP user agent Alias: Net-UserAgent-Detect
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221670
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From kevin@tummy.com 2007-01-13 19:15 EST ------- 1. Ok, looks good now.
2. Fair enough, just wanted to make sure you were aware of the issue.
I see no further blockers here, so this package is APPROVED.
Don't forget to close this review request NEXTRELEASE once it's been imported and built.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-UserAgent-Detect - Extract information from an HTTP user agent Alias: Net-UserAgent-Detect
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221670
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From chris.stone@gmail.com 2007-01-14 02:36 EST ------- - imported into cvs - updated owners.list - tagged and built for devel - cvs sync requested for fc5/6
THANKS FOR THE REVIEW!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-UserAgent-Detect - Extract information from an HTTP user agent Alias: Net-UserAgent-Detect
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221670
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium
chris.stone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From chris.stone@gmail.com 2007-05-01 23:03 EST ------- Package Change Request ====================== Package Name: php-pear-Net-UserAgent-Detect New Branches: EL-5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-UserAgent-Detect - Extract information from an HTTP user agent Alias: Net-UserAgent-Detect
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221670
dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From dennis@ausil.us 2007-05-05 11:27 EST ------- cvs done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: php-pear-Net-UserAgent-Detect - Extract information from an HTTP user agent Alias: Net-UserAgent-Detect
https://bugzilla.redhat.com/show_bug.cgi?id=221670
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org