https://bugzilla.redhat.com/show_bug.cgi?id=2211177
Bug ID: 2211177 Summary: Review Request: rust-codepage - Mapping between Windows code page numbers and encoding_rs character encodings Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: michel@michel-slm.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://salimma.fedorapeople.org/rust-codepage.spec SRPM URL: https://salimma.fedorapeople.org/rust-codepage-0.1.1-1.fc39.src.rpm
Description: Mapping between Windows code page numbers and encoding_rs character encodings.
Fedora Account System Username: salimma
https://bugzilla.redhat.com/show_bug.cgi?id=2211177
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |review-rust-codepage Doc Type|--- |If docs needed, set a value
https://bugzilla.redhat.com/show_bug.cgi?id=2211177
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2211182 | |(review-rust-calamine)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2211182 [Bug 2211182] Review Request: rust-calamine - Excel/OpenDocument Spreadsheets reader and deserializer in pure rust
https://bugzilla.redhat.com/show_bug.cgi?id=2211177
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review? CC| |decathorpe@gmail.com
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- Reading the crate description ... are you sure we actually need this crate on non-Windows?
https://bugzilla.redhat.com/show_bug.cgi?id=2211177
Michel Alexandre Salim michel@michel-slm.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(decathorpe@gmail. | |com)
--- Comment #2 from Michel Alexandre Salim michel@michel-slm.name --- (In reply to Fabio Valentini from comment #1)
Reading the crate description ... are you sure we actually need this crate on non-Windows?
It's a non-optional dependency for calamine: https://crates.io/crates/calamine/0.20.0/dependencies
Looks like you ... do need it to encode and decode Excel files. The horror!
https://github.com/search?q=repo%3Atafia%2Fcalamine%20codepage&type=code
https://bugzilla.redhat.com/show_bug.cgi?id=2211177
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ |needinfo?(decathorpe@gmail. | |com) |
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Ugh, well that sounds "sensible" then, I guess :D
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2211177
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-codepage
https://bugzilla.redhat.com/show_bug.cgi?id=2211177
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-9d87d6800a has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-9d87d6800a
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-221533f0a3 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-221533f0a3
https://bugzilla.redhat.com/show_bug.cgi?id=2211177
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-9d87d6800a has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-9d87d6800a
https://bugzilla.redhat.com/show_bug.cgi?id=2211177
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-cff5421604 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-cff5421604
https://bugzilla.redhat.com/show_bug.cgi?id=2211177
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-9d87d6800a has been pushed to the Fedora EPEL 9 testing repository.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-9d87d6800a
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2211177
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-cff5421604 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-cff5421604 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-cff5421604
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2211177
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-221533f0a3 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-221533f0a3 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-221533f0a3
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2211177
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2023-06-22 02:26:59
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-cff5421604 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2211177
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-221533f0a3 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2211177
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-9d87d6800a has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org