https://bugzilla.redhat.com/show_bug.cgi?id=1533719
Bug ID: 1533719 Summary: Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: sztsian@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://copr-be.cloud.fedoraproject.org/results/zsun/test/fedora-rawhide-x86... SRPM URL: https://copr-be.cloud.fedoraproject.org/results/zsun/test/fedora-rawhide-x86... Description: Optimized MPEG Audio Layer 2 encoding library based on tooLAME Fedora Account System Username: zsun
Legal approval: https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/...
Since mp3 is now allowed in Fedora, I am moving the package from RPMFusion to Fedora.
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
Iwicki Artur fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@svgames.pl
--- Comment #1 from Iwicki Artur fedora@svgames.pl ---
# fix HTML docs line endings for file in html/*.html ; do tr -d '\r' <$file >$file.unix && mv $file.unix $file done
Wouldn't it be simpler to use dos2unix here?
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
--- Comment #2 from Zamir SUN sztsian@gmail.com --- Oh, I try to keep it mostly as-is from rpmfusion. I can post an update if this is essential for a review.
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
Sergio Monteiro Basto sergio@serjux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sergio@serjux.com
--- Comment #3 from Sergio Monteiro Basto sergio@serjux.com --- Packages remaining to rebuild: fawkes kf5-libkface player
but player is FTBFS bug #1533278 , fawkes depends on player and kf5-libkface bug #1423813 was retired and add to Fedora fedora-obsolete-packages
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
--- Comment #4 from Zamir SUN sztsian@gmail.com --- (In reply to Sergio Monteiro Basto from comment #3)
Packages remaining to rebuild: fawkes kf5-libkface player
but player is FTBFS bug #1533278 , fawkes depends on player and kf5-libkface bug #1423813 was retired and add to Fedora fedora-obsolete-packages
Hi Sergio,
This is the review request of twolame. I believe you are commenting about kde related packages which is not about twolame. Let's keep this bug focused.
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
--- Comment #5 from Sergio Monteiro Basto sergio@serjux.com --- sorry wrote in wrong bug is was for bug 1530090 ...
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #6 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "*No copyright* LGPL", "*No copyright* Public domain", "LGPL (v2.1 or later)", "GPL (v2.1 or later) (with incorrect FSF address) LGPL (v2.1 or later)". 71 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/twolame/review- twolame/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 481280 bytes in 30 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in twolame- libs , twolame-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: twolame-0.3.13-8.fc28.x86_64.rpm twolame-libs-0.3.13-8.fc28.x86_64.rpm twolame-devel-0.3.13-8.fc28.x86_64.rpm twolame-debuginfo-0.3.13-8.fc28.x86_64.rpm twolame-debugsource-0.3.13-8.fc28.x86_64.rpm twolame-0.3.13-8.fc28.src.rpm twolame.x86_64: W: spelling-error Summary(en_US) tooLAME -> too Lame, too-lame, toolmaker twolame.x86_64: W: spelling-error %description -l en_US tooLAME -> too Lame, too-lame, toolmaker twolame.x86_64: W: spelling-error %description -l en_US www -> WWW, wow twolame.x86_64: W: spelling-error %description -l en_US sulaco -> consular twolame.x86_64: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end twolame.x86_64: W: only-non-binary-in-usr-lib twolame.x86_64: E: incorrect-fsf-address /usr/share/doc/twolame/README twolame.x86_64: E: incorrect-fsf-address /usr/share/licenses/twolame/COPYING twolame-libs.x86_64: W: spelling-error Summary(en_US) tooLAME -> too Lame, too-lame, toolmaker twolame-libs.x86_64: W: spelling-error %description -l en_US tooLAME -> too Lame, too-lame, toolmaker twolame-libs.x86_64: W: spelling-error %description -l en_US www -> WWW, wow twolame-libs.x86_64: W: spelling-error %description -l en_US sulaco -> consular twolame-libs.x86_64: W: no-documentation twolame-devel.x86_64: W: only-non-binary-in-usr-lib twolame-debugsource.x86_64: W: no-documentation twolame.src: W: spelling-error Summary(en_US) tooLAME -> too Lame, too-lame, toolmaker twolame.src: W: spelling-error %description -l en_US tooLAME -> too Lame, too-lame, toolmaker twolame.src: W: spelling-error %description -l en_US www -> WWW, wow twolame.src: W: spelling-error %description -l en_US sulaco -> consular twolame.src: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end twolame.src: W: invalid-url Source0: http://downloads.sourceforge.net/twolame/twolame-0.3.13.tar.gz <urlopen error _ssl.c:761: The handshake operation timed out> 6 packages and 0 specfiles checked; 2 errors, 19 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
Yaakov Selkowitz yselkowi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1534289
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1534289 [Bug 1534289] Enable twolame element
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
Yaakov Selkowitz yselkowi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1534291
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1534291 [Bug 1534291] Enable MP2 encoding with twolame
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
Yaakov Selkowitz yselkowi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1450227
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1450227 [Bug 1450227] audacity: enable MP2/MP3 output support
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
Yaakov Selkowitz yselkowi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1534297
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1534297 [Bug 1534297] Use twolame for MP2 encoding
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
Yaakov Selkowitz yselkowi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1534370
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1534370 [Bug 1534370] Requires: lame, twolame for MP2, MP3 encoding
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
--- Comment #7 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/twolame
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- twolame-0.3.13-9.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-95a02e792a
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
Zamir SUN sztsian@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(yselkowi@redhat.c | |om)
--- Comment #9 from Zamir SUN sztsian@gmail.com --- Hi Yaakov,
Now I built twolame for Rawhide and Fedora 27. If you need other branch, feel free to let me know.
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
Yaakov Selkowitz yselkowi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(yselkowi@redhat.c | |om) |
--- Comment #10 from Yaakov Selkowitz yselkowi@redhat.com --- Thanks! Good enough for me, but I imagine someone may want this in EPEL at some point.
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2018-01-17 11:20:21
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- twolame-0.3.13-9.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1533719
Sergio Monteiro Basto sergio@serjux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugzilla.redhat.com | |/show_bug.cgi?id=1186900
package-review@lists.fedoraproject.org