Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: <main package name here> - <short summary here>
https://bugzilla.redhat.com/show_bug.cgi?id=705109
Summary: Review Request: <main package name here> - <short summary here> Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: linux.n.pkd@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://prabindatta.fedorapeople.org/SPECS/python-qserve.spec SRPM URL: http://prabindatta.fedorapeople.org/SRPMS/python-qserve-0.0.1-1.fc14.src.rpm Description: qserve is used in python-mwlib. It's a job queue server written in python and it's missing documentation.
Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=3073913
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705109
--- Comment #1 from PRABIN KUMAR DATTA linux.n.pkd@gmail.com 2011-05-16 12:45:48 EDT --- [prabindatta@localhost ~]$ rpmlint -i rpmbuild/SPECS/python-qserve.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
--
[prabindatta@localhost ~]$ rpmlint -i rpmbuild/SRPMS/python-qserve-0.0.1-1.fc14.src.rpm python-qserve.src: W: spelling-error Summary(en_US) mwlib -> Malibu, Mowgli, millibar The value of this tag appears to be misspelled. Please double-check.
python-qserve.src: W: spelling-error %description -l en_US mwlib -> Malibu, Mowgli, millibar The value of this tag appears to be misspelled. Please double-check.
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
--
[prabindatta@localhost ~]$ rpmlint -i rpmbuild/RPMS/noarch/python-qserve-0.0.1-1.fc14.noarch.rpm python-qserve.noarch: W: spelling-error Summary(en_US) mwlib -> Malibu, Mowgli, millibar The value of this tag appears to be misspelled. Please double-check.
python-qserve.noarch: W: spelling-error %description -l en_US mwlib -> Malibu, Mowgli, millibar The value of this tag appears to be misspelled. Please double-check.
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705109
PRABIN KUMAR DATTA linux.n.pkd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: <main |Review Request: |package name here> - <short |python-qserve - Job queue |summary here> |server used in python-mwlib
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705109
--- Comment #2 from PRABIN KUMAR DATTA linux.n.pkd@gmail.com 2011-05-16 12:49:04 EDT --- Upstream reply about shebang:
/----
If the shebang is at all required after installation for
- /usr/lib/python2.7/site-packages/qs/qserve.py
- /usr/lib/python2.7/site-packages/qs/rpcserver.py
- /usr/lib/python2.7/site-packages/qs/slave.py
- /usr/lib/python2.7/site-packages/qs/jobs.py
- /usr/lib/python2.7/site-packages/qs/proc.py
no. ------/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705109
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@bernewireless.net
--- Comment #3 from Fabian Affolter fabian@bernewireless.net 2011-06-02 12:48:46 EDT --- You are working with a git checkout. Please follow the naming guidelines [1]. And please use %global instead of %define.
[1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705109
--- Comment #4 from PRABIN KUMAR DATTA linux.n.pkd@gmail.com 2011-06-02 14:45:48 EDT --- Updated:- Spec URL: http://prabindatta.fedorapeople.org/SPECS/python-qserve.spec SRPM URL: http://prabindatta.fedorapeople.org/SRPMS/python-qserve-0.0.1-2.1.git2011060...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705109
--- Comment #5 from Fabian Affolter fabian@bernewireless.net 2011-06-04 12:40:25 EDT --- You are adding a date to your release tag but your do not work with with an actual git queck-out. The source tarball is download from the github website and marked with the last commit checksum '31b9e43'.
You can take a look at the spec file in another review request [1]. This is the way I handle with the crappy github download in Source0.
Or check a past discussion [2] on the fedora-devel list.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=710386 [2] http://lists.fedoraproject.org/pipermail/devel/2011-February/148676.html
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705109
--- Comment #6 from Fabian Affolter fabian@bernewireless.net 2011-06-04 12:43:01 EDT --- The name schema could be
python-qserve-0-0.1.git31b9e43
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packag...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705109
--- Comment #7 from PRABIN KUMAR DATTA linux.n.pkd@gmail.com 2011-06-05 17:31:41 EDT --- Thanks, for sharing the links.
Updated:- Spec URL: http://prabindatta.fedorapeople.org/SPECS/python-qserve.spec SRPM URL: http://prabindatta.fedorapeople.org/SRPMS/python-qserve-0.0.1-3.fc15.src.rpm
I hope now it's ok!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705109
--- Comment #8 from Fabian Affolter fabian@bernewireless.net 2011-06-19 09:56:49 EDT --- Sorry, the naming is still wrong.
(In reply to comment #6)
The name schema could be
python-qserve-0-0.1.git31b9e43
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packag...
The naming should be the same as pre-release svn checkout are named.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705109
--- Comment #9 from PRABIN KUMAR DATTA linux.n.pkd@gmail.com 2011-06-19 13:11:44 EDT --- Updated package:- Spec URL: http://prabindatta.fedorapeople.org/SPECS/python-qserve.spec SRPM URL: http://prabindatta.fedorapeople.org/SRPMS/python-qserve-0.0.1-4.1.git31b9e43...
Now, is it Ok??
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705109
--- Comment #10 from Fabian Affolter fabian@bernewireless.net 2011-06-19 14:11:00 EDT --- (In reply to comment #9)
Updated package:- Spec URL: http://prabindatta.fedorapeople.org/SPECS/python-qserve.spec SRPM URL: http://prabindatta.fedorapeople.org/SRPMS/python-qserve-0.0.1-4.1.git31b9e43...
Now, is it Ok??
No, according to your versioning scheme the packed version is 0.0.1 but in fact it's a prerelease meaning version 0, see Comment #8.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705109
--- Comment #11 from PRABIN KUMAR DATTA linux.n.pkd@gmail.com 2011-06-19 15:55:27 EDT --- SRPMS Name: python-qserve-0-0.0.1-4.1.fc15.src.rpm
Now??
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705109
--- Comment #12 from Fabian Affolter fabian@bernewireless.net 2011-06-19 16:49:22 EDT --- (In reply to comment #11)
SRPMS Name: python-qserve-0-0.0.1-4.1.fc15.src.rpm
Sorry, it gets worse...Please stop guessing and read my comments. Just place a 0 as version tag and leave the release tag unchanged is not the right way. In comment #6 was the right release tag already mentioned.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705109
--- Comment #13 from PRABIN KUMAR DATTA linux.n.pkd@gmail.com 2011-06-20 07:23:29 EDT --- Sorry, I disturbed you a lot. Actually, I have read your comments but I was confused that: 1. I have already done initial build as 0.0.1-1. 2. So, for next change log, if it's ok to use 0-0.1.gitxxxx since version 0 < version 0.0.1
After conversation with Ankur Sinha on IRC channel. I have removed all change logs and resubmitting this package.
Spec URL: http://prabindatta.fedorapeople.org/SPECS/python-qserve.spec SRPM URL: http://prabindatta.fedorapeople.org/SRPMS/python-qserve-0-0.1.git31b9e43.fc1...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705109
Ian Weller ian@ianweller.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ian@ianweller.org Flag| |needinfo?(linux.n.pkd@gmail | |.com)
--- Comment #14 from Ian Weller ian@ianweller.org 2012-02-02 13:48:05 EST --- Hello,
This review request appears stalled. I am requesting a response from the submitter of this review under this policy: https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews If the reviewer does not respond within one week I will close this review request.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=705109
Ian Weller ian@ianweller.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NOTABUG Flag|needinfo?(linux.n.pkd@gmail | |.com) | Last Closed| |2012-02-09 15:04:02
--- Comment #15 from Ian Weller ian@ianweller.org 2012-02-09 15:04:02 EST --- Pursuant to the policy for stalled package reviews, I am closing this review request.
package-review@lists.fedoraproject.org