https://bugzilla.redhat.com/show_bug.cgi?id=2279546
Bug ID: 2279546 Summary: Review Request: rust-sqlx-sqlite - SQLite driver implementation for SQLx Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@lecris.me QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://github.com/LecrisUT/sqlx-rpmspec/raw/b8d1b82fdbcf7e5292f2c61076ac42c... SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-sqlx-rpms... Description: Part of `sqlx` Fedora Account System Username: lecris
rust2rpm.toml: ```toml [[package.extra-patches]] comments = [ "https://github.com/launchbadge/sqlx/pull/3148", "Also fix libsqlite3 features", ] file = "sqlx-sqlite-0.7.4-Fix_libsqlite3-sys.patch" number = 10
[tests] comments = [ "resolve dependency loop with sqlx", ] run = ["none"] ```
https://bugzilla.redhat.com/show_bug.cgi?id=2279546
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2268045, 2279513, 2279537 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2268045 [Bug 2268045] Review Request: rust-atoi - Parse integers directly from [u8] slices in safe code. https://bugzilla.redhat.com/show_bug.cgi?id=2279513 [Bug 2279513] Review Request: rust-futures-intrusive - Futures based on intrusive data structures - for std and no-std environments https://bugzilla.redhat.com/show_bug.cgi?id=2279537 [Bug 2279537] Review Request: rust-sqlx-core - Core of SQLx, the rust SQL toolkit. Not intended to be used directly
https://bugzilla.redhat.com/show_bug.cgi?id=2279546
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/sq | |lx-sqlite
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7424589 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2279546
Cristian Le fedora@lecris.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2279547
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2279547 [Bug 2279547] Review Request: rust-sqlx - The Rust SQL Toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=2279546 Bug 2279546 depends on bug 2279513, which changed state.
Bug 2279513 Summary: Review Request: rust-futures-intrusive - Futures based on intrusive data structures - for std and no-std environments https://bugzilla.redhat.com/show_bug.cgi?id=2279513
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2279546
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com CC| |zebob.m@gmail.com
--- Comment #2 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - Grab license files from https://github.com/launchbadge/sqlx and reference this bug for resolution of the situation:
https://github.com/launchbadge/sqlx/issues/3237
- License ok - Latest version packaged - Builds in mock - Checks pass - No rpmlint errors - Conforms to Go Packaging Guidelines
Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2279546
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- see also my comment here: https://bugzilla.redhat.com/show_bug.cgi?id=2279542#c3
https://bugzilla.redhat.com/show_bug.cgi?id=2279546
--- Comment #4 from Cristian Le fedora@lecris.me --- Spec URL: https://github.com/LecrisUT/sqlx-rpmspec/raw/bcb99b4c4cf9566d8da58eb5eb90b0f... SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-sqlx-rpms... Description: Part of `sqlx` Fedora Account System Username: lecris
rust2rpm.toml: ```toml [[package.extra-sources]] number = 10 file = "https://github.com/launchbadge/sqlx/raw/v%%7Bversion%7D/LICENSE-APACHE" comments = [ "Fix missing LICENSE-* files in released crates", "https://github.com/launchbadge/sqlx/issues/3237", ] [[package.extra-sources]] number = 11 file = "https://github.com/launchbadge/sqlx/raw/v%%7Bversion%7D/LICENSE-MIT" comments = [ "Fix missing LICENSE-* files in released crates", "https://github.com/launchbadge/sqlx/issues/3237", ]
[scripts.prep] pre = ["cp -p '%{SOURCE10}' '%{SOURCE11}' ."]
[package] extra-files = [ "%license %{crate_instdir}/LICENSE-APACHE", "%license %{crate_instdir}/LICENSE-MIT", ]
[[package.extra-patches]] comments = [ "https://github.com/launchbadge/sqlx/pull/3148", "Also fix libsqlite3 features", ] file = "sqlx-sqlite-0.7.4-Fix_libsqlite3-sys.patch" number = 10
[tests] comments = [ "resolve dependency loop with sqlx", ] run = ["none"] ```
https://bugzilla.redhat.com/show_bug.cgi?id=2279546
--- Comment #5 from Cristian Le fedora@lecris.me --- Adding a patch for https://github.com/launchbadge/sqlx/pull/3281
---
Spec URL: https://github.com/LecrisUT/sqlx-rpmspec/raw/227de9cd3f36532deebfda883cac9bf... SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/LecrisUT-sqlx-rpms...
rust2rpm.toml: ```toml [[package.extra-sources]] number = 10 file = "https://github.com/launchbadge/sqlx/raw/v%%7Bversion%7D/LICENSE-APACHE" comments = [ "Fix missing LICENSE-* files in released crates", "https://github.com/launchbadge/sqlx/issues/3237", ] [[package.extra-sources]] number = 11 file = "https://github.com/launchbadge/sqlx/raw/v%%7Bversion%7D/LICENSE-MIT" comments = [ "Fix missing LICENSE-* files in released crates", "https://github.com/launchbadge/sqlx/issues/3237", ]
[scripts.prep] pre = ["cp -p '%{SOURCE10}' '%{SOURCE11}' ."]
[package] extra-files = [ "%license %{crate_instdir}/LICENSE-APACHE", "%license %{crate_instdir}/LICENSE-MIT", ] cargo-toml-patch-comments = [ "- Bump libsqlite3 dependency: https://github.com/launchbadge/sqlx/pull/3148", "- Fix libsqlite3 features", ]
[[package.extra-patches]] comments = [ "https://github.com/launchbadge/sqlx/pull/3281", "Add SQLITE_OPEN_URI to all in-memory sqlite", ] file = "sqlx-sqlite-0.7.4-Fix_openuri_flag.patch" number = 10
[tests] comments = [ "resolve dependency loop with sqlx", ] run = ["none"] ```
package-review@lists.fedoraproject.org