Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=343871
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: silfreed@silfreed.net QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://www.silfreed.net/download/repo/packages/qlandkarte/qlandkarte.spec SRPM URL: http://www.silfreed.net/download/repo/packages/qlandkarte/qlandkarte-0.5.3-2... Description: Provides a GUI to visualize data from GPS device's tracks and maps.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |dan@danny.cz Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From dan@danny.cz 2007-10-20 12:40 EST ------- - License tag should be GPLv2+, the source files contain "version 2 or any later" - missing BuildRequires: proj-devel libusb-devel (+desktop-file-utils) - as it is a GUI application a desktop file must be provided - the parallel make command should be "make %{?_smp_mflags}" - QLANDKARTE_LIBDIR (defined in QLandkarte/common) is used for plugins and they must be installed in %{_libdir}/..., so hardcoding /usr/lib/ works only for 32-bit architectures - QMAKE_CXXFLAGS_RELEASE (defined in QLandkarte/common) set to -O3 overrides Fedora's default level (-O2) - in the %files section the %{_libdir}/%{name} directory is not owned, you can use it as it includes the *.so too
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
------- Additional Comments From dan@danny.cz 2007-10-20 12:40 EST ------- Created an attachment (id=233471) --> (https://bugzilla.redhat.com/attachment.cgi?id=233471&action=view) update fro the spec file
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
------- Additional Comments From dan@danny.cz 2007-10-20 12:41 EST ------- Created an attachment (id=233481) --> (https://bugzilla.redhat.com/attachment.cgi?id=233481&action=view) desktop file
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
------- Additional Comments From dan@danny.cz 2007-10-20 12:47 EST ------- Created an attachment (id=233491) --> (https://bugzilla.redhat.com/attachment.cgi?id=233491&action=view) patch for the spec file to fix the issues with QLandkarte/common
update QLandkarte/common after unpacking the sources in %prep
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
------- Additional Comments From silfreed@silfreed.net 2007-10-22 09:44 EST ------- Spec URL: http://www.silfreed.net/download/repo/packages/qlandkarte/qlandkarte.spec SRPM URL: http://www.silfreed.net/download/repo/packages/qlandkarte/qlandkarte-0.5.3-3...
%changelog * Mon Oct 22 2007 Douglas E. Warner silfreed@silfreed.net 0.5.3-3 - spec file patches and desktop file by Dan Horak dan@danny.cz GPLv2+ desktop file use sed to cleanup problems in makefile additional BuildRequires
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From dan@danny.cz 2007-10-22 11:27 EST ------- I have done yet a few changes: - separated the earth icon from icons.cpp and used it as an icon for the desktop file - disabled the parallel make build as it doesn't work, it looks like that the build system doesn't define _smp_mflags, so it is buildable in Koji, but on my machine it crashes. Probably there are missing some inter-file dependencies, but it is a qmake problem.
The review is here: OK source files match upstream: a995b5ae55263975ba5de36f164094c2b18f8951 QLandkarte.2007.09.18.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (GPLv2+). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (development/i386) + in koji. OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK is a GUI app, desktop file is included
This package is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #233481|0 |1 is obsolete| |
------- Additional Comments From dan@danny.cz 2007-10-22 11:28 EST ------- Created an attachment (id=234181) --> (https://bugzilla.redhat.com/attachment.cgi?id=234181&action=view) new desktop file
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
------- Additional Comments From dan@danny.cz 2007-10-22 11:28 EST ------- Created an attachment (id=234191) --> (https://bugzilla.redhat.com/attachment.cgi?id=234191&action=view) icon for the desktop file
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #233471|0 |1 is obsolete| |
------- Additional Comments From dan@danny.cz 2007-10-22 11:29 EST ------- Created an attachment (id=234201) --> (https://bugzilla.redhat.com/attachment.cgi?id=234201&action=view) updates for the spec file
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #233491|0 |1 is obsolete| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
------- Additional Comments From silfreed@silfreed.net 2007-10-22 12:23 EST ------- Spec URL: http://www.silfreed.net/download/repo/packages/qlandkarte/qlandkarte.spec SRPM URL: http://www.silfreed.net/download/repo/packages/qlandkarte/qlandkarte-0.5.3-4...
%changelog * Mon Oct 22 2007 Douglas E. Warner silfreed@silfreed.net 0.5.3-4 - including icon for desktop file - disabling parallel make flags
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
silfreed@silfreed.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From silfreed@silfreed.net 2007-10-22 12:25 EST ------- New Package CVS Request ======================= Package Name: qlandkarte Short Description: A tool to visualize maps and other GPS information for Garmin devices Owners: silfreed, sharkcz Branches: FC-6 F-7 F-8 devel Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-10-22 15:42 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
silfreed@silfreed.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
silfreed@silfreed.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
------- Additional Comments From updates@fedoraproject.org 2007-10-24 03:14 EST ------- qlandkarte-0.5.3-4.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update qlandkarte'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
------- Additional Comments From updates@fedoraproject.org 2007-11-05 16:57 EST ------- qlandkarte-0.5.3-4.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |CLOSED Resolution|NEXTRELEASE |ERRATA Fixed In Version| |0.5.3-4.fc7
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
------- Additional Comments From updates@fedoraproject.org 2007-11-06 11:15 EST ------- qlandkarte-0.5.3-4.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update qlandkarte'
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: qlandkarte - A tool to visualize maps and other GPS information for Garmin devices
https://bugzilla.redhat.com/show_bug.cgi?id=343871
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
------- Additional Comments From updates@fedoraproject.org 2007-12-20 15:12 EST ------- qlandkarte-0.5.3-4.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=343871
Dan Horák dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #17 from Dan Horák dan@danny.cz 2008-12-23 11:43:52 EDT --- Package Change Request ====================== Package Name: qlandkarte New Branches: EL-5 Owners: sharkcz
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=343871
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #18 from Kevin Fenzi kevin@tummy.com 2008-12-24 19:43:16 EDT --- cvs done.
package-review@lists.fedoraproject.org