https://bugzilla.redhat.com/show_bug.cgi?id=2227277
Bug ID: 2227277 Summary: Review Request: cdecl - C gibberish translator Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@svgames.pl QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
spec: https://suve.fedorapeople.org/review/cdecl-14.2-1/cdecl.spec srpm: https://suve.fedorapeople.org/review/cdecl-14.2-1/cdecl-14.2-1.fc38.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=104021474
Description: cdecl is a program that translates C language declarations into pseudo-English, like "int(*fn[2])(void*)" into "declare fn as an array 2 of pointer to function (pointer to void) returning integer". It can also do the inverse, generating C declarations from English phrases.
Fedora Account System Username: suve
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/paul-j-l | |ucas/cdecl/
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6220374 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
Artur Frenszek-Iwicki fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #2 from Artur Frenszek-Iwicki fedora@svgames.pl --- Updated to v14.3.
spec: https://suve.fedorapeople.org/review/cdecl-14.3-1/cdecl.spec srpm: https://suve.fedorapeople.org/review/cdecl-14.3-1/cdecl-14.3-1.fc38.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=105613981
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #3 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1986594 --> https://bugzilla.redhat.com/attachment.cgi?id=1986594&action=edit The .spec file difference from Copr build 6220374 to 6362997
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6362997 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #5 from Artur Frenszek-Iwicki fedora@svgames.pl --- Updated to v14.4.
spec: https://suve.fedorapeople.org/review/cdecl-14.4-1/cdecl.spec srpm: https://suve.fedorapeople.org/review/cdecl-14.4-1/cdecl-14.4-1.fc38.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=106274534
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #6 from Artur Frenszek-Iwicki fedora@svgames.pl --- Updated to v15.0.
spec: https://suve.fedorapeople.org/review/cdecl-15.0-1/cdecl.spec srpm: https://suve.fedorapeople.org/review/cdecl-15.0-1/cdecl-15.0-1.fc39.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=106998498
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
Tom Rix trix@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |trix@redhat.com Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |trix@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #7 from Tom Rix trix@redhat.com --- I am concerned about the relicensing. This is public domain.
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #8 from Artur Frenszek-Iwicki fedora@svgames.pl --- I've brought the question up on the legal mailing list, and the answer there was that this should be OK to package. https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/...
We can still open a ticket on the license-data GitLab, or mark this as blocked by FE-LEGAL, for further review.
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #9 from Tom Rix trix@redhat.com --- Ok, sound reasonable. Since this is complicated, I think you should add the link and the entire text to the spec file. repost spec and srpm and I will go forward with the review.
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #10 from Artur Frenszek-Iwicki fedora@svgames.pl --- Huh. I've updated the spec and then forgot to make a comment here. Anyway. Updated to v16.1.
spec: https://suve.fedorapeople.org/review/cdecl-16.1-1/cdecl.spec srpm: https://suve.fedorapeople.org/review/cdecl-16.1-1/cdecl-16.1-1.fc39.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=112560612
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #11 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2011904 --> https://bugzilla.redhat.com/attachment.cgi?id=2011904&action=edit The .spec file difference from Copr build 6362997 to 6971775
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #12 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6971775 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- Not a valid SPDX expression 'GPL-3.0-or-later AND LGPL-2.1-or-later AND LicenseRef-Fedora-PublicDomain'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #13 from Artur Frenszek-Iwicki fedora@svgames.pl --- Updated to v16.2.1.
spec: https://suve.fedorapeople.org/review/cdecl-16.2.1-1/cdecl.spec srpm: https://suve.fedorapeople.org/review/cdecl-16.2.1-1/cdecl-16.2.1-1.fc39.src.... koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=113804640
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #14 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2017961 --> https://bugzilla.redhat.com/attachment.cgi?id=2017961&action=edit The .spec file difference from Copr build 6971775 to 7042156
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #15 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7042156 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #16 from Artur Frenszek-Iwicki fedora@svgames.pl --- Updated to v16.2.2.
spec: https://suve.fedorapeople.org/review/cdecl-16.2.2-1/cdecl.spec srpm: https://suve.fedorapeople.org/review/cdecl-16.2.2-1/cdecl-16.2.2-1.fc39.src.... koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=114335183
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #17 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2019788 --> https://bugzilla.redhat.com/attachment.cgi?id=2019788&action=edit The .spec file difference from Copr build 7042156 to 7097401
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #18 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7097401 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
Xavier Bachelot xavier@bachelot.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier@bachelot.org Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #19 from Artur Frenszek-Iwicki fedora@svgames.pl --- Updated to v16.3.
spec: https://suve.fedorapeople.org/review/cdecl-16.3-1/cdecl.spec srpm: https://suve.fedorapeople.org/review/cdecl-16.3-1/cdecl-16.3-1.fc40.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=117023308
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
Tom Rix trix@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #20 from Tom Rix trix@redhat.com --- Thanks for documenting the license discussion. Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #21 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/cdecl
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-4ff196a896 (cdecl-16.3-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4ff196a896
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-4ff196a896 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4ff196a896 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4ff196a896
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-4f37316d6a has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-4f37316d6a` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-4f37316d6a
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
--- Comment #25 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-3e6bb779ce has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3e6bb779ce` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3e6bb779ce
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2227277
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2024-06-06 01:38:12
--- Comment #26 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-3e6bb779ce (cdecl-16.4.1-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org