Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-CPAN-Meta-YAML - Read and write a subset of YAML for CPAN Meta files
https://bugzilla.redhat.com/show_bug.cgi?id=672807
Summary: Review Request: perl-CPAN-Meta-YAML - Read and write a subset of YAML for CPAN Meta files Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: paul@city-fan.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-CPAN-Meta-YAML/branches/f... SRPM URL: http://www.city-fan.org/~paul/extras/perl-CPAN-Meta-YAML/perl-CPAN-Meta-YAML...
Description: This module implements a subset of the YAML specification for use in reading and writing CPAN metadata files like META.yml and MYMETA.yml. It should not be used for any other general YAML parsing or generation task.
This module is currently derived from YAML::Tiny by Adam Kennedy. If there are bugs in how it parses a particular META.yml file, please file a bug report in the YAML::Tiny bugtracker: http://rt.cpan.org/NoAuth/ReportBug.html?Queue=YAML-Tiny
The EPEL-4/EPEL-5 builds of this package depend on perl-Test-CPAN-Meta and perl-Parse-CPAN-Meta, which are en route through the QA process so it'll be a month or so before they're buildable in the absence of some people testing them and giving them enough karma to get to stable earlier.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |672665
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |iarnell@gmail.com AssignedTo|nobody@fedoraproject.org |iarnell@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #1 from Iain Arnell iarnell@gmail.com 2011-01-26 23:27:25 EST --- + source files match upstream. 62d0f9726a2b91971b2f3f4ac770de5d CPAN-Meta-YAML-0.003.tar.gz
+ package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. Though I would lose the 2nd paragraph - it's not really relevant for a package description
+ dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic
+ license is open source-compatible. + license text included + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=2744924
+ package installs properly. + rpmlint has no complaints: perl-CPAN-Meta-YAML.noarch: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsus perl-CPAN-Meta-YAML.noarch: W: spelling-error %description -l en_US bugtracker -> bug tracker, bug-tracker, nutcracker perl-CPAN-Meta-YAML.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsus perl-CPAN-Meta-YAML.src: W: spelling-error %description -l en_US bugtracker -> bug tracker, bug-tracker, nutcracker 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
+ final provides and requires are sane: perl(CPAN::Meta::YAML) = 0.003 perl-CPAN-Meta-YAML = 0.003-2.fc15 = perl(:MODULE_COMPAT_5.12.3) perl(strict)
+ %check is present and all tests pass. + make test 'TEST_FILES=t/*.t xt/*/*.t' PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t xt/*/*.t t/01_compile.t ........... ok t/02_basic.t ............. ok t/03_regression.t ........ ok t/04_scalar.t ............ ok t/05_export.t ............ ok t/11_meta_yml.t .......... ok t/12_plagger.t ........... ok t/13_perl_smith.t ........ ok t/14_yaml_org.t .......... ok t/15_multibyte.t ......... ok t/16_nullrefs.t .......... ok t/17_toolbar.t ........... ok t/18_tap.t ............... ok t/19_errors.t ............ ok t/20_subclass.t .......... ok t/21_bom.t ............... ok t/22_comments.t .......... ok xt/release/distmeta.t .... ok xt/release/pod-syntax.t .. ok All tests successful. Files=19, Tests=3448, 2 wallclock secs ( 0.36 usr 0.05 sys + 1.79 cusr 0.23 csys = 2.43 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package.
My only minor gripe is that the 2nd paragraph of %description isn't really relevant for us.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
Paul Howarth paul@city-fan.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #2 from Paul Howarth paul@city-fan.org 2011-01-27 09:02:24 EST --- I've trimmed the description in the spec now.
Thanks for the review.
New Package SCM Request ======================= Package Name: perl-CPAN-Meta-YAML Short Description: Read and write a subset of YAML for CPAN Meta files Owners: pghmcfc Branches: f13 f14 el4 el5 el6 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
--- Comment #3 from Jason Tibbitts tibbs@math.uh.edu 2011-01-27 10:06:28 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
--- Comment #4 from Fedora Update System updates@fedoraproject.org 2011-01-27 11:30:06 EST --- perl-CPAN-Meta-YAML-0.003-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/perl-CPAN-Meta-YAML-0.003-3.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2011-01-27 11:30:12 EST --- perl-CPAN-Meta-YAML-0.003-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-CPAN-Meta-YAML-0.003-3.el6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2011-01-27 11:30:19 EST --- perl-CPAN-Meta-YAML-0.003-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-CPAN-Meta-YAML-0.003-3.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2011-02-04 14:48:11 EST --- perl-CPAN-Meta-YAML-0.003-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-02-04 14:51:05 EST --- perl-CPAN-Meta-YAML-0.003-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-02-12 19:21:51 EST --- perl-CPAN-Meta-YAML-0.003-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-02-27 13:56:23 EST --- Package perl-CPAN-Meta-YAML-0.003-3.el4: * should fix your issue, * was pushed to the Fedora EPEL 4 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing perl-CPAN-Meta-YAML-0.003-3.el4' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/perl-CPAN-Meta-YAML-0.003-3.el4 then log in and leave karma (feedback).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-02-27 15:30:31 EST --- Package perl-CPAN-Meta-YAML-0.003-3.el5: * should fix your issue, * was pushed to the Fedora EPEL 5 updates-testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing perl-CPAN-Meta-YAML-0.003-3.el5' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/perl-CPAN-Meta-YAML-0.003-3.el5 then log in and leave karma (feedback).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-02-28 18:59:22 EST --- perl-CPAN-Meta-YAML-0.003-3.el4 has been pushed to the Fedora EPEL 4 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-CPAN-Meta-YAML'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-CPAN-Meta-YAML-0.003-3.el4
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-03-15 14:23:58 EDT --- perl-CPAN-Meta-YAML-0.003-3.el4 has been pushed to the Fedora EPEL 4 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |perl-CPAN-Meta-YAML-0.003-3 | |.el4 Resolution| |ERRATA Last Closed| |2011-03-15 14:24:04
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=672807
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2011-03-15 14:24:42 EDT --- perl-CPAN-Meta-YAML-0.003-3.el5 has been pushed to the Fedora EPEL 5 stable repository.
package-review@lists.fedoraproject.org