https://bugzilla.redhat.com/show_bug.cgi?id=1252812
Telles Nobrega <tenobreg(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tenobreg(a)redhat.com
--- Comment #7 from Telles Nobrega <tenobreg(a)redhat.com> ---
This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
ones are mandatory, though)
- Remove this text
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package installs properly.
Note: Installation errors (see attachment)
See:
https://fedoraproject.org/wiki/Packaging:Guidelines
- Dist tag is present.
- Package does not use a name that already exists.
Note: A package with this name already exists. Please check
https://admin.fedoraproject.org/pkgdb/acls/name/openstack-ironic-python-
agent
See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Pac...
===== MUST items =====
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Apache (v2.0)", "Unknown or generated", "*No
copyright* Apache
(v2.0)". 24 files have unknown license. Detailed output of
licensecheck in /home/tenobreg/review-packages/1257329-openstack-
ironic-python-agent/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[X]: Python eggs must not download any dependencies during the build
process.
[ ]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
-ironic-python-agent , python2-ironic-python-agent-doc
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[!]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[!]: Rpmlint is run on all installed packages.
Note: Mock build failed
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[x]: Spec file according to URL is the same as in SRPM.
Installation errors
-------------------
INFO: mock.py version 1.2.13 starting (python version = 3.4.2)...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled yum cache
Start: cleaning yum metadata
Finish: cleaning yum metadata
INFO: enabled ccache
Mock Version: 1.2.13
INFO: Mock Version: 1.2.13
Finish: chroot init
INFO: installing package(s):
/home/tenobreg/review-packages/1257329-openstack-ironic-python-agent/results/openstack-ironic-python-agent-0.1-0.1.gite6439ca1d06a50e72b97975da9b3963ba04ba841.noarch.rpm
/home/tenobreg/review-packages/1257329-openstack-ironic-python-agent/results/python2-ironic-python-agent-0.1-0.1.gite6439ca1d06a50e72b97975da9b3963ba04ba841.noarch.rpm
/home/tenobreg/review-packages/1257329-openstack-ironic-python-agent/results/python2-ironic-python-agent-doc-0.1-0.1.gite6439ca1d06a50e72b97975da9b3963ba04ba841.noarch.rpm
ERROR: Command failed. See logs for output.
# /usr/bin/yum-deprecated --installroot /var/lib/mock/fedora-22-x86_64/root/
--releasever 22 install
/home/tenobreg/review-packages/1257329-openstack-ironic-python-agent/results/openstack-ironic-python-agent-0.1-0.1.gite6439ca1d06a50e72b97975da9b3963ba04ba841.noarch.rpm
/home/tenobreg/review-packages/1257329-openstack-ironic-python-agent/results/python2-ironic-python-agent-0.1-0.1.gite6439ca1d06a50e72b97975da9b3963ba04ba841.noarch.rpm
/home/tenobreg/review-packages/1257329-openstack-ironic-python-agent/results/python2-ironic-python-agent-doc-0.1-0.1.gite6439ca1d06a50e72b97975da9b3963ba04ba841.noarch.rpm
--setopt=tsflags=nocontexts
Rpmlint
-------
Checking:
openstack-ironic-python-agent-0.1-0.1.gite6439ca1d06a50e72b97975da9b3963ba04ba841.noarch.rpm
python2-ironic-python-agent-0.1-0.1.gite6439ca1d06a50e72b97975da9b3963ba04ba841.noarch.rpm
python2-ironic-python-agent-doc-0.1-0.1.gite6439ca1d06a50e72b97975da9b3963ba04ba841.noarch.rpm
openstack-ironic-python-agent-0.1-0.1.gite6439ca1d06a50e72b97975da9b3963ba04ba841.src.rpm
openstack-ironic-python-agent.noarch: W: spelling-error Summary(en_US)
deprovisioning -> processioning
openstack-ironic-python-agent.noarch: W: spelling-error %description -l en_US
ramdisk -> ram disk, ram-disk, radish
openstack-ironic-python-agent.noarch: W: spelling-error %description -l en_US
unprovisioned -> unprovided
openstack-ironic-python-agent.noarch: W: spelling-error %description -l en_US
pxe -> exp, pee, pie
openstack-ironic-python-agent.noarch: W: incoherent-version-in-changelog
0.1.0-0.1.gite6439ca1d06a50e72b97975da9b3963ba04ba841
['0.1-0.1.gite6439ca1d06a50e72b97975da9b3963ba04ba841',
'0.1-0.1.gite6439ca1d06a50e72b97975da9b3963ba04ba841']
openstack-ironic-python-agent.noarch: W: no-manual-page-for-binary
ironic-python-agent
python2-ironic-python-agent.noarch: W: summary-ended-with-dot C Python library
for the ironic python agent.
python2-ironic-python-agent.noarch: W: no-documentation
python2-ironic-python-agent-doc.noarch: W: summary-ended-with-dot C
Documentation for ironic python agent.
openstack-ironic-python-agent.src: W: spelling-error Summary(en_US)
deprovisioning -> processioning
openstack-ironic-python-agent.src: W: spelling-error %description -l en_US
ramdisk -> ram disk, ram-disk, radish
openstack-ironic-python-agent.src: W: spelling-error %description -l en_US
unprovisioned -> unprovided
openstack-ironic-python-agent.src: W: spelling-error %description -l en_US pxe
-> exp, pee, pie
openstack-ironic-python-agent.src:84: W: macro-in-comment %{upstream_version}
openstack-ironic-python-agent.src: W: invalid-url Source0:
ironic-python-agent-0.1.0.dev731.tar.gz
4 packages and 0 specfiles checked; 0 errors, 15 warnings.
Requires
--------
python2-ironic-python-agent-doc (rpmlib, GLIBC filtered):
openstack-ironic-python-agent (rpmlib, GLIBC filtered):
/bin/sh
/usr/bin/python2
config(openstack-ironic-python-agent)
python-ironic-python-agent
systemd
python2-ironic-python-agent (rpmlib, GLIBC filtered):
python(abi)
python-babel
python-eventlet
python-iso8601
python-netifaces
python-oslo-concurrency
python-oslo-config
python-oslo-i18n
python-oslo-log
python-oslo-serialization
python-oslo-service
python-oslo-utils
python-pbr
python-pecan
python-pint
python-psutil
python-pyudev
python-requests
python-six
python-stevedore
python-wsme
Provides
--------
python2-ironic-python-agent-doc:
python2-ironic-python-agent-doc
openstack-ironic-python-agent:
config(openstack-ironic-python-agent)
openstack-ironic-python-agent
python2-ironic-python-agent:
python-ironic-python-agent
python2-ironic-python-agent
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
Command line :/usr/bin/fedora-review -b 1257329
Buildroot used: fedora-22-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component