Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483569
Parag AN(पराग) <panemade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade(a)gmail.com
AssignedTo|nobody(a)fedoraproject.org |panemade(a)gmail.com
Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade(a)gmail.com> 2009-02-02 11:24:27 EDT
---
Review:
+ package builds in mock (rawhide i386).
koji build =>
http://koji.fedoraproject.org/koji/taskinfo?taskID=1099489
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
91ca075f77cd9922e36a100c59b6f383 MooseX-Types-Set-Object-0.02.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
Files=1, Tests=15, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.32 cusr 0.02
csys = 0.35 CPU)
+ Package perl-MooseX-Types-Set-Object-0.02-1.fc11 ->
Provides: perl(MooseX::Types::Set::Object) = 0.02
Requires: perl(MooseX::Types) perl(MooseX::Types::Moose) perl(Scalar::Util)
perl(Set::Object) perl(base) perl(strict) perl(warnings)
APPROVED.
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.