Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: erlang-log4erl - A logger for erlang in the spirit of Log4J
https://bugzilla.redhat.com/show_bug.cgi?id=632186
Summary: Review Request: erlang-log4erl - A logger for erlang in the spirit of Log4J Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: lemenkov@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://peter.fedorapeople.org/erlang-log4erl.spec SRPM URL: http://peter.fedorapeople.org/erlang-log4erl-0.9.0-1.fc12.src.rpm Description: A logger for erlang in the spirit of Log4J
It's one of the requirements for many large Erlang applications.
Koji scratchbuilds:
F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2457221 EL-5: http://koji.fedoraproject.org/koji/taskinfo?taskID=2457224
rpmlint:
Sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/ppc/erlang-log4erl-0.9.0-1.fc12.ppc.rpm erlang-log4erl.ppc: E: explicit-lib-dependency erlang-stdlib erlang-log4erl.ppc: W: invalid-url URL: http://code.google.com/p/log4erl/ <urlopen error timed out> erlang-log4erl.ppc: E: no-binary erlang-log4erl.ppc: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 2 errors, 2 warnings. Sulaco ~/rpmbuild/SPECS:
All the above messages should be ignored:
* explicit-lib-dependency is just a bogus message due to explicit dependency on erlang-stdlib (note 'lib' in its name) * invalid-url - seems some network failures on my build machine or something like this * no-binary - this package install in arch-specific path (required by main Erlang/OTP framework), but in fact it's noarch * only-non-binary-in-usr-lib - likewise
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
--- Comment #1 from Peter Lemenkov lemenkov@gmail.com 2010-09-26 05:15:22 EDT --- New package:
http://peter.fedorapeople.org/erlang-log4erl.spec http://peter.fedorapeople.org/erlang-log4erl-0.9.0-2.fc12.src.rpm
%changelog: - Narrow BuildRequires
Koji scratchbuild for F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2489808
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |pbrobinson@gmail.com AssignedTo|nobody@fedoraproject.org |pbrobinson@gmail.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
--- Comment #2 from Peter Robinson pbrobinson@gmail.com 2010-09-26 17:38:59 EDT --- Mostly OK. License needs to be fixed, and there's a few errors in rpmlint.
+ rpmlint output
rpmlint erlang-log4erl-0.9.0-2.fc14.x86_64.rpm erlang-log4erl.x86_64: E: explicit-lib-dependency erlang-stdlib erlang-log4erl.x86_64: E: no-binary erlang-log4erl.x86_64: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 2 errors, 1 warnings.
+ package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora - license matches the actual package license License is MPL-1.1 and BSD + latest version packaged
+ %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm 6fb55aac281e5fdf61d6778a06bf8108 log4erl-0.9.0.tar.gz + package successfully builds on at least one architecture tested using koji scratch build + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr + package owns all directories it creates n/a no duplicate files in %files + Package perserves timestamps on install + %defattr line + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package runtime n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a devel must require the fully versioned base + packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + filenames must be valid UTF-8
Optional:
+ if there is no license file, packager should query upstream to include it n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock/koji n/a the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described + scriptlets should be sane n/a non -devel packages should require fully versioned base n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin n/a Package should have man files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
--- Comment #3 from Peter Robinson pbrobinson@gmail.com 2010-09-27 03:27:04 EDT --- (In reply to comment #2)
Mostly OK. License needs to be fixed, and there's a few errors in rpmlint.
Forget the comments about rpmlint I missed the notes regarding them. Just the license to deal with.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
--- Comment #4 from Peter Lemenkov lemenkov@gmail.com 2010-09-27 04:13:11 EDT --- Done:
http://peter.fedorapeople.org/erlang-log4erl.spec http://peter.fedorapeople.org/erlang-log4erl-0.9.0-3.fc12.src.rpm
Fixed license tag (also added note about the only file, licensed under ERPL).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #5 from Peter Robinson pbrobinson@gmail.com 2010-09-27 04:30:19 EDT --- Looks good. APPROVED!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #6 from Peter Lemenkov lemenkov@gmail.com 2010-09-27 04:51:44 EDT --- Thanks!
New Package SCM Request ======================= Package Name: erlang-log4erl Short Description: A logger for erlang in the spirit of Log4J Owners: peter Branches: f12 f13 f14 el6 el5 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
--- Comment #7 from Kevin Fenzi kevin@tummy.com 2010-09-27 19:13:01 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2010-09-28 01:23:12 EDT --- erlang-log4erl-0.9.0-3.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/erlang-log4erl-0.9.0-3.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2010-09-28 01:23:20 EDT --- erlang-log4erl-0.9.0-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/erlang-log4erl-0.9.0-3.el5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2010-09-28 01:23:27 EDT --- erlang-log4erl-0.9.0-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/erlang-log4erl-0.9.0-3.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-09-28 01:23:33 EDT --- erlang-log4erl-0.9.0-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/erlang-log4erl-0.9.0-3.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-09-28 13:32:30 EDT --- erlang-log4erl-0.9.0-3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-log4erl'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/erlang-log4erl-0.9.0-3.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2010-10-08 08:39:01 EDT --- erlang-log4erl-0.9.0-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |erlang-log4erl-0.9.0-3.fc14 Resolution| |ERRATA Last Closed| |2010-10-08 08:39:06
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2010-10-08 16:34:50 EDT --- erlang-log4erl-0.9.0-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|erlang-log4erl-0.9.0-3.fc14 |erlang-log4erl-0.9.0-3.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
--- Comment #15 from Fedora Update System updates@fedoraproject.org 2010-10-08 16:56:24 EDT --- erlang-log4erl-0.9.0-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|erlang-log4erl-0.9.0-3.fc13 |erlang-log4erl-0.9.0-3.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
--- Comment #16 from Fedora Update System updates@fedoraproject.org 2010-10-13 01:55:11 EDT --- erlang-log4erl-0.9.0-3.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|erlang-log4erl-0.9.0-3.fc12 |erlang-log4erl-0.9.0-3.el5
package-review@lists.fedoraproject.org