Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=911781
Eduardo Echeverria <echevemaster(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |echevemaster(a)gmail.com
--- Comment #1 from Eduardo Echeverria <echevemaster(a)gmail.com> ---
Hi Giuseppe
About review process
Perhaps you have tried to register at any time when the platform was not
available, however, and the expectation that you are searching a different url,
you retry with this.
https://admin.fedoraproject.org/accounts/
These links may be useful:
-
https://fedoraproject.org/wiki/Package_Review_Process#Contributor
-
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelin...
Is good practice paste the rpmlint output in the review, and at least make a
build scratch on koji and paste the link in the review
https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds
Please tag the field "Blocks" with the word FE-NEEDSPONSOR. So, will let you
know the sponsors you need sponsorship
About the package
I have not thoroughly checked the package, but at first glance, I give some
recommendations
You have a typo in this line
URL:
http://http://bittwist.sourceforge.net/
in %install
make install prefix=${RPM_BUILD_ROOT}/usr
should be
make install DESTDIR=%{buildroot} PREFIX=%{_prefix}
(if $DESTDIR supports)
Check it
$ rpm --eval %{_prefix}
/usr
the description should not be more than 80 characters per line, rpmlit
complains with description-line-too-long
- Please do honors applicable compiler flags, Use %{optflags}
Check it
$ rpm --eval %{optflags}
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic
Check the makefile and do the patch, (do not forget to send the patch to
upstream)
bittwist:
$(CC) $(CFLAGS) $(SRC)/bittwist.c -o $(SRC)/bittwist
-I/usr/local/include -L/usr/local/lib -lpcap
bittwiste:
$(CC) $(CFLAGS) $(SRC)/bittwiste.c -o $(SRC)/bittwiste
-I/usr/local/include -L/usr/local/lib -lpcap
- the tag license is wrong
License: GPL2
should be
License: GPLv2
the changelog is wrong
%changelog
* Fri Feb 15 2013 Giuseppe Marco Randazzo <gmrandazzo(a)gmail.com>
- first build for bittwist
should be
%changelog
* Fri Feb 15 2013 Giuseppe Marco Randazzo <gmrandazzo(a)gmail.com> - 2.0-1
- first build for bittwist
https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
- Don't needed %defattr(-,root,root)
Kind Regards
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=8VFX8a51Nx&a=cc_unsubscribe