https://bugzilla.redhat.com/show_bug.cgi?id=1352996
Bug ID: 1352996 Summary: Review Request: python-zipstream - A zip archive generator for Python Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: athmanem@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://athmane.fedorapeople.org/pkgs/gns3/python-zipstream.spec SRPM URL: https://athmane.fedorapeople.org/pkgs/gns3/python-zipstream-1.1.4-1.fc24.src... Description: zipstream.py is a zip archive generator based on python 3.3's zipfile.py. It was created to generate a zip file generator for streaming (ie web apps)
Fedora Account System Username: athmane
https://bugzilla.redhat.com/show_bug.cgi?id=1352996
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ignatenko@redhat.com Assignee|nobody@fedoraproject.org |ignatenko@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1352996
--- Comment #1 from Athmane Madjoudj athmanem@gmail.com --- New SPEC/SRPMS:
Spec URL: https://athmane.fedorapeople.org/pkgs/gns3/python-zipstream.spec SRPM URL: https://athmane.fedorapeople.org/pkgs/gns3/python-zipstream-1.1.4-2.fc24.src...
https://bugzilla.redhat.com/show_bug.cgi?id=1352996
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
--- Comment #2 from Igor Gnatenko ignatenko@redhat.com ---
%global sum A zip archive generator for Python
drop this line
Name: python-zipstream
Name: python-%{srcname}
Summary: A zip archive generator for Python
Summary: ZIP archive generator for Python
License: GPLv3
License: GPLv3+
URL: https://github.com/allanlei/%%7Bname%7D
Source0: https://github.com/allanlei/python-zipstream/archive/v%%7Bversion%7D.tar.gz
Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz
BuildRequires: python3-devel python-devel
Drop this lines
%package -n python2-%{srcname} Summary: %{sum}
Summary: %{summary} BuildRequires: python2-devel
%description -n python2-%{srcname} %{desc}
Python 2 version.
... same for python3 ...
%autosetup -n %{name}-%{version}
%autosetup
nosetests-%{python2_version} -v
Why not %{__python2} setup.py test?
... same for python3 ...
https://bugzilla.redhat.com/show_bug.cgi?id=1352996
--- Comment #3 from Igor Gnatenko ignatenko@redhat.com --- Ah, also missing BuildRequires: pythonX-setuptools
https://bugzilla.redhat.com/show_bug.cgi?id=1352996
--- Comment #4 from Athmane Madjoudj athmanem@gmail.com --- Thanks for reviewing, bellow the updated SPEC/SRPM:
Spec URL: https://athmane.fedorapeople.org/pkgs/gns3/python-zipstream.spec SRPM URL: https://athmane.fedorapeople.org/pkgs/gns3/python-zipstream-1.1.4-3.fc24.src...
https://bugzilla.redhat.com/show_bug.cgi?id=1352996
--- Comment #5 from Igor Gnatenko ignatenko@redhat.com --- python-setuptools -> python2-setuptools python-nose -> python2-nose
also move BuildRequires under python2/python3 subpackages
%autosetup -n %{name}-%{version}
still not fixed. remove "-n %{name}-%{version}
%{desc} should be with "." in the end.
https://bugzilla.redhat.com/show_bug.cgi?id=1352996
--- Comment #6 from Athmane Madjoudj athmanem@gmail.com --- Fix.
Spec URL: https://athmane.fedorapeople.org/pkgs/gns3/python-zipstream.spec SRPM URL: https://athmane.fedorapeople.org/pkgs/gns3/python-zipstream-1.1.4-4.fc24.src...
https://bugzilla.redhat.com/show_bug.cgi?id=1352996
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #7 from Igor Gnatenko ignatenko@redhat.com --- Everything is according to packaging guidelines.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1352996
Igor Gnatenko ignatenko@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |python-zipstream
https://bugzilla.redhat.com/show_bug.cgi?id=1352996
Athmane Madjoudj athmanem@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |python-zipstream - A zip |python-zipstream - ZIP |archive generator for |archive generator for |Python |Python
https://bugzilla.redhat.com/show_bug.cgi?id=1352996
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-zipstream
https://bugzilla.redhat.com/show_bug.cgi?id=1352996
Athmane Madjoudj athmanem@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2016-07-11 17:59:44
--- Comment #9 from Athmane Madjoudj athmanem@gmail.com --- Built in rawhide and f24, I forgot to add the bug # to the update, now it's locked :P
package-review@lists.fedoraproject.org