[Bug 2254717] New: Review Request: python-expandvars - Expand system variables Unix style
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
Bug ID: 2254717 Summary: Review Request: python-expandvars - Expand system variables Unix style Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: code@musicinmybrain.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://music.fedorapeople.org/python-expandvars.spec SRPM URL: https://music.fedorapeople.org/python-expandvars-0.12.0-1.fc39.src.rpm Description:
This module is inspired by GNU bash’s variable expansion features. It can be used as an alternative to Python’s os.path.expandvars function.
A good use case is reading config files with the flexibility of reading values from environment variables using advanced features like returning a default value if some variable is not defined.
Fedora Account System Username: music
This is a trivial pure-Python package required for the current version of python-frozenlist, which in turn is a dependency for python-aiohttp and python-aiosignal.
I plan to add the new “-l” option for %pyproject_save_files to assert the presence of a properly-packaged license file once pyproject-rpm-macros 1.11.0 reaches stable in all current releases (https://bodhi.fedoraproject.org/updates/?packages=pyproject-rpm-macros). For now, I have manually confirmed it with “rpm -qL -p /python3-expandvars-0.12.0-1.fc40.noarch.rpm” (expected output: /usr/lib/python3.12/site-packages/expandvars-0.12.0.dist-info/licenses/LICENSE).
Koji scratch builds: F40: https://koji.fedoraproject.org/koji/taskinfo?taskID=110378314 F39: https://koji.fedoraproject.org/koji/taskinfo?taskID=110378315 F38: https://koji.fedoraproject.org/koji/taskinfo?taskID=110378316
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2254700 Whiteboard| |Trivial Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2254700 [Bug 2254700] python-frozenlist-1.4.1 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6760098 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
Maxwell G maxwell@gtmx.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ CC| |maxwell@gtmx.me Assignee|nobody@fedoraproject.org |maxwell@gtmx.me
--- Comment #2 from Maxwell G maxwell@gtmx.me --- Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The license text is included and marked with %license. - [x] The package builds successfully in mock. - [x] The package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The packager considers avoiding confusing `%foo_name` macros. (Not a blocker) - [x] Libraries: The package name has a `python3-` prefix and uses the canonical project name - [x] The pyproject macros are used. - [x] There are no bundled libraries. - [x] The package complies with the Python and general Packaging Guidelines.
Package approved! On import, don't forget to add the package to release-monitoring.org. You can give @python-packagers-sig `commit` if you wish`
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
--- Comment #3 from Ben Beasley code@musicinmybrain.net --- Thank you for the review!
I’ve waded into simple Rust reviews lately, so I’ll try to take a look at bug 2254855 when I have some time.
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-expandvars
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
--- Comment #5 from Ben Beasley code@musicinmybrain.net --- Added to release-monitoring.org: https://release-monitoring.org/project/95228/
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
--- Comment #6 from Ben Beasley code@musicinmybrain.net --- Added python-sig with commit privileges and configured Koschei (https://koschei.fedoraproject.org/package/python-expandvars?collection=f40).
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-d7fbfb0d0d has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d7fbfb0d0d
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2023-12-18 15:57:09
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-d7fbfb0d0d has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-c4d698b7e9 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-c4d698b7e9
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8d65575379 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8d65575379
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-5a8d22d786 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a8d22d786
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-5a8d22d786 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-5a8d22d786 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a8d22d786
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-c4d698b7e9 has been pushed to the Fedora EPEL 9 testing repository.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-c4d698b7e9
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8d65575379 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8d65575379 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8d65575379
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2023-c4d698b7e9 has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8d65575379 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-5a8d22d786 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2024-ff796b1196 (python-expandvars-0.12.0-7.el10_0) has been submitted as an update to Fedora EPEL 10.0. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-ff796b1196
https://bugzilla.redhat.com/show_bug.cgi?id=2254717
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- FEDORA-EPEL-2024-ff796b1196 (python-expandvars-0.12.0-7.el10_0) has been pushed to the Fedora EPEL 10.0 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com