Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=461794
Fabian Affolter <fabian(a)bernewireless.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fabian(a)bernewireless.net
Flag| |needinfo?(dwmw2(a)infradead.o
| |rg)
--- Comment #1 from Fabian Affolter <fabian(a)bernewireless.net> 2008-09-13 04:04:38
EDT ---
There is a new version available. 0.3.9. Maybe you should update the spec.
This is only an informal review because it's my second.
RPM Lint: ok
Package name: ok
Spec file: ok
- use 'Source0:
'http://www.nopcode.org/0xFFFF/get/%{name}-%{version}.tar.gz'
instead of 'Source0:
http://www.nopcode.org/0xFFFF/get/0xFFFF-0.3.2.tar.gz'
- %description: At the end of the sentence is one point enough.
- use macros like %{_bindir}/%{name} instead %{_bindir}/0xFFFF
https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Ma...
License: ok
Actual License: ok
%doc License: ok
Spec file language: ok
Spec file readable: ok
Upstream source vs. used tarball: md5 match ( debf8b40ad293fdf6ca19cdf4e461276
)
Compile and Build:
- F-8: ok
- F-9: ok
- rawhide: ok
Applicable Package Guidelines:
Locales: n/a
Shared libs: n/a
Relocatable: n/a
Directory and file ownership: ok
No duplicate files in %files: ok
File Permissions: ok
Macro usage: check above
Code vs. Content: ok
(Large) Documentation: n/a
%doc affecting runtime: ok
Header files in -devel package: n/a
Static Libraries in -static package: n/a
pkgconfig Requires: n/a
Library files: ok
Devel requires base package: n/a
.la libtool archives: ok
Duplicate ownership of files/directories: ok
Remove BuildRoot: ok
UTF-8 filenames: ok
In the tarball is a directory 'gui'. Does this package provide a GUI? If yes, a
.desktop file would be nice to integrate it in the desktop environment.
https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.