https://bugzilla.redhat.com/show_bug.cgi?id=2182358
Javier Martinez Canillas <fmartine(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fmartine(a)redhat.com
--- Comment #5 from Javier Martinez Canillas <fmartine(a)redhat.com> ---
Everything looks to me, the only comment I've is that the Fedora package policy
has a very precise naming for packages that are built from git snapshots rather
than released tarballs versions. And the package doesn't follow the guidelines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_sn...
In short, you need to have something like following diff to your current SPEC
(I've not tested this though so there may be some typos):
diff --git a/unzboot.spec b/unzboot.spec
index 7e845fee4575..9dd816eab379 100644
--- a/unzboot.spec
+++ b/unzboot.spec
@@ -1,15 +1,19 @@
-%global gitversion 3285b558
+%global commit 3285b558529b862391d27afe098368d6f8dda09e
+%global shortcommit %(c=%{commit}; echo ${c:0:7})
+%global commitdate 20230318
Name: unzboot
-Version: 0.1
-Release: 1.git%{gitversion}%{?dist}
+Version: 0.1~git.%{commitdate}.%{shortcommit}
+Release: 1%{?dist}
Summary: Extracts a kernel vmlinuz image from a EFI application.
License: MIT
-# git snapshot. to recreate, run:
-# ./make-git-snapshot.sh `cat commitid`
-Source0: unzboot-%{gitversion}.tar.xz
+# Upstream is still under development so they are not tagging releases
+# yet. Use the following to do a rebase to a new snapshot:
+#
+# git archive --format=tar --prefix=${name}-${shortcommit}/ ${shortcommit} |
xz > ${name}-${shortcommit}.tar.xz
+Source0: %{name}-%{shortcommit}.tar.xz
BuildRequires: gcc
BuildRequires: glib2-devel
@@ -22,7 +26,7 @@ a EFI application that carries the actual kernel image in
compressed form.
%prep
-%setup -q -n %{name}-%{gitversion}
+%autosetup -n %{name}-%{shortcommit}
%build
%meson
%meson_build
@@ -37,5 +41,5 @@ compressed form.
%{_bindir}/unzboot
%changelog
-* Sat Mar 18 2023 Enric Balletbo i Serra <eballetbo(a)redhat.com> -
0.1-1.git3285b558
+* Sat Mar 18 2023 Enric Balletbo i Serra <eballetbo(a)redhat.com> -
0.1~git.20210928.e00149f-1
- initial unzboot spec
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2182358