https://bugzilla.redhat.com/show_bug.cgi?id=2022208
Bug ID: 2022208 Summary: Review Request: rust-unic-langid-impl - API for managing Unicode Language Identifiers Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: link@sub-pop.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... SRPM URL: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora... Description: API for managing Unicode Language Identifiers Fedora Account System Username: linkdupont Fedora Review: https://download.copr.fedorainfracloud.org/results/linkdupont/reviews/fedora...
https://bugzilla.redhat.com/show_bug.cgi?id=2022208
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review+ Doc Type|--- |If docs needed, set a value
--- Comment #1 from Neal Gompa ngompa13@gmail.com --- Package was generated through rust2rpm, simplifying the review considerably.
- Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - only sources installed
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2022208
--- Comment #2 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-unic-langid-impl
https://bugzilla.redhat.com/show_bug.cgi?id=2022208
--- Comment #3 from Link Dupont link@sub-pop.net --- https://bodhi.fedoraproject.org/updates/FEDORA-2021-293b6ec93f
https://bugzilla.redhat.com/show_bug.cgi?id=2022208
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
https://bugzilla.redhat.com/show_bug.cgi?id=2022208
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-01f7520709 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2022208
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Sorry for the noise, but for completeness, I accidentally commented with some issues in this package on the wrong review request: https://bugzilla.redhat.com/show_bug.cgi?id=2022205#c5
TL;DR: This package *does* contain binaries (and it shouldn't), overriding double-underscored-macros like __cargo_skip_build is a bad idea (those are not meant to be set in .spec files), and the macro was removed with rust2rpm 20. Please use an alternative method of disabling those binaries (as outlined in the linked comment).
https://bugzilla.redhat.com/show_bug.cgi?id=2022208
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
https://bugzilla.redhat.com/show_bug.cgi?id=2022208
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-01f7520709 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-01f7520709
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2022208
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2021-12-11 01:30:42
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2021-01f7520709 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org