https://bugzilla.redhat.com/show_bug.cgi?id=960201
--- Comment #17 from Björn "besser82" Esser bjoern.esser@gmail.com --- (In reply to Michael Schwendt from comment #16)
Or may I reassign this to someone else?
;) I don't claim ownership of this review.
Allrighty! ;)
But note that there are issues with the package:
License: LGPLv2 or LGPLv3
First of all, the source files include a "GPLv2" preamble, modified with links to Novell and novell.com instead of gnu.org. That's a case of:
https://fedoraproject.org/wiki/Packaging: LicensingGuidelines#License_Clarification
Already in progress: https://github.com/libyui/libyui-qt-graph/pull/15 I *could* merge myself, but I'll let that open for discussion with the SUSE-folks… 8)
Secondly, with regard to the LGPLv3, the GPLv3 license text should be included as well:
As above. ^^
rpmlint complains about the -doc package with an 'E':
libyui-qt-graph-doc.noarch: E: version-control-internal-file
/usr/share/doc/libyui-qt-graph-doc/examples/.gitignore
Fixed, see below.
- The -devel package pkgconfig file specifies "Libs: -lyui-qt-graph", but
that lib is located outside default search path in the plugin dir %_libdir/yui/.
Which really ain't an issue here, but will need fixing in libyui-pkg itself, because the other UI-plugins are affected by this as well. Hmmmmm… Who did the review on them? :-P By e.g. adding /etc/ldconf.so.conf.d/libyui-%{%_arch}.conf to the libyui-pkg (already done: https://koji.fedoraproject.org/koji/buildinfo?buildID=519016). SO-dependencies will make sure this one is pulled in any case.
#####
%changelog * Sat May 24 2014 Björn Esser bjoern.esser@gmail.com - 2.44.1-2 - fix rpmlint 'E: version-control-internal-file'
Koji Builds:
el7: http://koji.fedoraproject.org/koji/taskinfo?taskID=6887224 F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=6887227 F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6887230 Frh: http://koji.fedoraproject.org/koji/taskinfo?taskID=6887234
Urls:
Spec URL: http://besser82.fedorapeople.org/review/libyui-qt-graph.spec SRPM URL: http://besser82.fedorapeople.org/review/libyui-qt-graph-2.44.1-2.fc21.src.rp...