Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=500476
Igor Jurišković juriskovic.igor@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |juriskovic.igor@gmail.com
--- Comment #3 from Igor Jurišković juriskovic.igor@gmail.com 2009-05-18 16:17:52 EDT --- Hello Louis.
This is not official review. I'm looking for a sponsor like you. ---------------------------------------------------------------- - remove Vendor tag. Its not needed. ----------------------------------------------------------------
---------------------------------------------------------------- - Consider using parallel make if possible. If not write in comment above make why not. https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make ----------------------------------------------------------------
---------------------------------------------------------------- - install doesn't preserve timestamps. Add INSTALL="install -p" like: make DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" install http://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25install_sectio... ----------------------------------------------------------------
---------------------------------------------------------------- - update package to new version. ----------------------------------------------------------------
---------------------------------------------------------------- - I'm unable to download source but are you sure that License is only GPL? If possible be more specific like GPLv3+... ----------------------------------------------------------------
---------------------------------------------------------------- - %doc part can go into one line. Its easier to read but its your choice. ----------------------------------------------------------------
---------------------------------------------------------------- - you need to make space between changelogs:
* Thu Mar 12 2009 Louis Lagendijk llagendijk@users.sourceforge.net - something
* Thu Feb 19 2009 Louis Lagendijk llagendijk@users.sourceforge.net - something
* ...
---------------------------------------------------------------- - you're missing "-" at the beginning of some changes. ----------------------------------------------------------------
---------------------------------------------------------------- - changelog part is missing version and release number:
* Thu Mar 12 2009 Louis Lagendijk llagendijk@users.sourceforge.net <version>-<release> ----------------------------------------------------------------