Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480567
Jochen Schmitt jochen@herr-schmitt.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #5 from Jochen Schmitt jochen@herr-schmitt.de 2009-01-22 12:17:38 EDT --- Good: + Could downloaded upstream tar ball via spectool -g + Packaged tar ball matches with upstream one. (md5sum: c998c8050c77c14eda496b26891bb4c1) + License GPLv2+ is matches with the copyright notice in the course file + Local build works fine + Build on koji works fine.
TDDO: + You need on add a extran '%' to escape the specila '%' char in the %changelog stanza. Escaping the '$' character is no necessary in the %changelog stanza, so you can write
* Wed Jan 21 2009 Paul Wouters paul@xelerance.com - 1.13-1 - Clarify license - Fix mixed use of $RPM_BUILD_ROOT and %%{buildroot} - Source tag fully qualified now
*** APPROVED ***