https://bugzilla.redhat.com/show_bug.cgi?id=2087174
Mamoru TASAKA mtasaka@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@fedoraproject.org
--- Comment #2 from Mamoru TASAKA mtasaka@fedoraproject.org --- So as I happen to be telepathy-glib maintainer, I comment for now.
* Now for new packages License field must use SPDX identifier:
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline... https://spdx.org/licenses/
* For BuildRequires: using "BuildRequires: pkgconfig(foo)" is preferred than to use "BuildRequires: dbus-glib-devel" or so
https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequ...
* Unneeded BR - At least "BR: openssl-devel" seems unneeded - Also check if there is any more unneeded BRs left.
* Using "python-unversioned-command" as BR is strongly discouraged. Patch out not to use non-version python and use python3.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependenc...
* scratch build says: checking for Python with Twisted and IRC protocol support... no https://koji.fedoraproject.org/koji/taskinfo?taskID=91402714 Looking at configure.ac, this perhaps means that some twisted tests are disabled. Please consider to enable this.
* Directory ownership: https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories... With "mock --init" and doint "mock --install telepathy-idle.x86_64.rpm", /usr/share/dbus-1/services/ is not owned by any packages. ============================================================= [mockbuild@93f3667e0cdb434cb87064920e66e928 ~]$ rpm -qf /usr/share/dbus-1/services/ file /usr/share/dbus-1/services is not owned by any package ============================================================= Make it sure this directory is owned by some package when telepathy-idle is installed.