Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=563510
--- Comment #9 from Timon <timosha(a)gmail.com> 2010-02-11 06:27:59 EST ---
(In reply to comment #4)
is this your first package ?
exactly, no. I'm not approved
yet, but already have two review requests
(#464141,#464117).
(In reply to comment #5)
As I'm not approved, I could only provide an unofficial review:
thanks
* can not verify license (BSD given in SPEC, couldn't find this
in code, esp.
COPYING does not mention BSD)
http://xcache.lighttpd.net/changeset/45
I added COPYING to %doc dir.
* Mixing $RPM_BUILD_ROOT and %{buildroot} should not be done (cf.
Packaging
guidelines in Fedora wiki)
fixed
* some code in SPEC is commented out, decreases readability. Why
don't you
remove those lines? Why is code for RHEL 4 and RHEL 5 included?
fixed
(In reply to comment #6)
I recommend you to put this out of spec file.
%{__cat} > %{buildroot}%{_sysconfdir}/php.d/xcache.ini << 'EOF'
[xcache-common]
zend_extension = %{php_extdir}/xcache.so
[xcache.admin]
xcache.admin.enable_auth = On
xcache.admin.user = "mOo"
; xcache.admin.pass = md5($your_password)
xcache.admin.pass = ""
[xcache]
xcache.shm_scheme = "mmap"
xcache.size = 60M
xcache.count = 1
xcache.slots = 8K
xcache.ttl = 3600
xcache.gc_interval = 300
xcache.var_size = 4M
xcache.var_count = 1
xcache.var_slots = 8K
xcache.var_ttl = 0
xcache.var_maxttl = 0
xcache.var_gc_interval = 300
EOF
fixed
spec:
https://bugzilla.redhat.com/attachment.cgi?id=390219
srpm:
https://bugzilla.redhat.com/attachment.cgi?id=390220
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.