https://bugzilla.redhat.com/show_bug.cgi?id=2049301
--- Comment #4 from Tomas Orsava torsava@redhat.com --- (In reply to Ondřej Kania from comment #3)
Hello Tomas! Thanks for mentioning these issues.
- Period and unnecessary comments removed.
Beware, I see the period was removed from `%description`, where it actually should be :) The description contains a full paragraph describing what the package does, so it's ok to have sentences and periods there. But in the `Summary: ` tag it should be just a short description, not a sentence. So please remove the dot from the Summary and add it back to `%description`. No stress, this happens. :)
- Basically, argcomplete > 2 is already in upstream but we cannot use it
because the patch also changes files which we dont even have.
Ah, that makes sense. How about changing the comment slightly like this? # argcomplete > 2 is already allowed upstream but the # relevant upstream commit also changes files not included in the release tarball.
- I accidentally used wrong tarball, should be fine now.
Perfect.
- I tried to swap it and looks like it works. :)
It looks so much better now, I love it!
But the sad news is, it doesn't do what we want. It seems the %exlude is applied only to the `%{python3_sitelib}/nox/tox_to_nox.py` file, but not te the files in the `__pycache__` directory that go with it (`%{python3_sitelib}/nox/__pycache__/tox_to_nox.cpython-310.opt-1.pyc` and `%{python3_sitelib}/nox/__pycache__/tox_to_nox.cpython-310.pyc`), which are listed using the `%pycached` macro. That means these files are actually listed in both subpackages, and that's wrong.
So with a sad heart, please switch the %pycached and %exclude macros to the original position. Thanks for trying it though!