Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: cronolog - Web log rotation program for Apache
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224684
ville.skytta@iki.fi changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |ville.skytta@iki.fi OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From ville.skytta@iki.fi 2007-01-27 02:56 EST ------- - "strip src/cronolog" needs to go, let rpmbuild take care of it and produce a usable debuginfo package.
- Use "make install DESTDIR=..." instead of %makeinstall http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0...
- Why is the info file removed instead of being included and properly installed? http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#info
- The man page refers to /www/sbin/cronolog which could be replaced by the actual installation path, /usr/sbin/cronolog
- Would /usr/bin be a more appropriate install path for cronosplit than /usr/sbin?
- INSTALL is useless in %doc, and should be dropped.