https://bugzilla.redhat.com/show_bug.cgi?id=2163447
--- Comment #11 from hardt(a)kit.edu ---
Issues:
=======
- Dist tag is present.
OK: fedora-review does not understand rpmautospec
I'm not sure what to do
here:
- I don't find any "dist" in the spec file, and according to
https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/ it is
not forbidden.
- Package does not contain duplicates in %files.
Note: warning: File listed twice: /usr/include/mustach
See:
https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_duplicate_files
I think you want to remove this line:
%{_includedir}/mustach
…which means the directory /usr/bin/mustach plus all of its contents. In the
following lines, you have correctly listed just the directory
%dir %{_includedir}/mustach
and listed individual headers in the various devel packages.
The extra line also means that %{_includedir}/mustach/mustach-cjson.h and
%{_includedir}/mustach/mustach-jansson.h are (co-)owned by
mustach-lib-core-devel rather than only by the backend-specific -devel
packages, which is unintended.
Thanks! Fixed.
- The dependency on mustach-lib-core from mustach-lib-core-devel
should be
fully versioned and arched. Change:
Fixed.
[...]
===== MUST items =====
[...]
===== SHOULD items =====
Generic:
[...]
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mustach-
lib-core , mustach-lib-core-devel , mustach-lib-json-c , mustach-lib-
json-c-devel , mustach-lib-cjson , mustach-lib-cjson-devel , mustach-
lib-jansson , mustach-lib-jansson-devel
should be fixed
[...]
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2163447