Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=710995
--- Comment #5 from Volker Fröhlich volker27@gmx.at 2011-07-11 16:55:15 EDT --- Don't parse "ls". Using the find command is a lot cleaner. Something like:
find . -type f ( -name "*.cpp" -o -name "*.h" -o -name "*.c" -o -name "*.xpm" ) -exec chmod a-x {} ;
You're missing the .desktop file and icons though. I'd just chmod the whole src directory.
Don't install the documentation manually. Use the %doc macro instead (and put it first under %files -- that is common). Please visit the RPM documentation on how to use it.
Ad iconv: Try iconv -f iso-8859-1 -t utf-8 dicomfformat_8c.xml
(Probably put that desktop file comment above the three seds. You might want to start your comments with either a capital letter or not, but not mix it, but that is just a question of style and not necessary for the review.)