Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-pydns - Another Pyhon DNS library.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204560
------- Additional Comments From kevin@tummy.com 2006-08-29 23:18 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. See below - License See below - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. See below - Sources match upstream md5sum: OK - Package compiles and builds on at least one arch. OK - BuildRequires correct See below - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: See below - Should include License or ask upstream to include it. OK - Should build in mock.
Issues:
1. Should the license really be "Python Software Foundation License" and not "Python license" ? a grep in the unpacked source gives: PKG-INFO:License: Python license README.txt:This code is released under a Python-style license. setup.py: license = 'Python license',
2. You should provide a full path to the source in Source0. Perhaps something like: Source0: http://easynews.dl.sourceforge.net/sourceforge/pydns/ pydns-%{version}.tgz
3. You need to own the %{python_sitelib}/DNS/ directory, not just it's contents.
4. rpmlint says: W: python-pydns summary-ended-with-dot Python module for DNS (Domain Name Service). Suggest: remove the . at the end of the summary line.
5. You BuildRequire python-setuptools, according to the python package guidelines ( at http://fedoraproject.org/wiki/Packaging/Python ), "Python packages that use setuptools need to add python-setuptools as a BuildRequires and must either add --single-version-externally-managed to the line invoking setup.py in %install, or must add a .pth file containing the path to the egg or egg directory to %{python_sitelib}." Should this package do that? Or does it really need python-setuptools at all?