Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gedit-plugins - Collections of plugins for gedit
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225066
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium
------- Additional Comments From trond.danielsen@gmail.com 2007-03-27 03:15 EST ------- (In reply to comment #5)
- I've waited for new gedit in Rawhide. This breaks the package
finally:
checking for GEDIT... configure: error: Package requirements ( glib-2.0 >= 2.8.0 gtk+-2.0 >= 2.8.0 gtksourceview-1.0 >= 1.2.0 gedit-2.14 >= 2.15.7 libglade-2.0 >= 2.4.0 gnome-vfs-2.0 >= 2.13.4 ) were not met:
No package 'gedit-2.14' found
- Much newer gedit-plugins tarballs are available upstream.
But FC6 only has 2.15.9, and gedit-plugins/2.15.5 is the latest version that compiles with that version of gedit. I will initally create a version for FC6, and then upgrade it to the latest version in rawhide.
- Build on FC-6 fails, too, and disables python-vte plugin. This
is because rpmbuild unsets $DISPLAY, which is needed by the configure check:
$ unset DISPLAY $ python -c "import vte" Traceback (most recent call last): File "<string>", line 1, in ? ImportError: could not import gtk $ python -c "import gtk" Traceback (most recent call last): File "<string>", line 1, in ? File "/usr/lib/python2.4/site-packages/gtk-2.0/gtk/__init__.py", line 76, in ? _init() File "/usr/lib/python2.4/site-packages/gtk-2.0/gtk/__init__.py", line 64, in
_init
_gtk.init_check()
RuntimeError: could not open display
This is currently the biggest show stopper. I'll look into it and see what I can come up with.
- Some minor requests:
Please really drop the package name from the Summary. When the package name is repeated in the summary, this looks very ugly wherever %name and %summary are displayed next to eachother, e.g. repoview pages and other forms of package listings.
FIXED.
BuildRequires: perl-XML-Parser
BuildRequires: perl(XML::Parser)
Please prefer Perl module names over package names, as they are less likely to break when a module is moved to a different package.
FIXED.
killall -HUP gconfd-2 || :
In the scriptlets is not needed for FC5 and newer.
FIXED.
Sorry for the delay; I will release a new version very soon.