https://bugzilla.redhat.com/show_bug.cgi?id=2215174
Jeremy Newton alexjnewt@fastmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+
--- Comment #9 from Jeremy Newton alexjnewt@fastmail.com --- You could probably use:
%{_docdir}/%{name} %{_datadir}/cmake/%{name}
For consistency.
I tested building rocsparse and it builds fine, but since it's a mix of C++ and Fortran, it made me realise that we should probably not muck around with global optflags, but rather just only change c++, like so:
%global build_cxxflags %(echo %{optflags} | sed -e 's/-fstack-protector-strong/-Xarch_host -fstack-protector-strong/' -e 's/-fcf-protection/-Xarch_host -fcf-protection/')
It also simplifies the sed hackery. I'll been patching rocrand shortly with this.
Anyway, not huge blockers.
Approved.