Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: piklab - Development environment for applications based on PIC and dsPIC microcontrollers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208250
------- Additional Comments From Jochen@herr-schmitt.de 2006-09-27 14:54 EST ------- Good: + Local build works fine. + Local install/uninstall works fine. + Program starts without complains. + Tar ball in source package matches with upstream. + Mock build works fine.
Bad:
- Rpmlint of source package complaints: pmlint piklab-0.11.3-1.src.rpm E: piklab summary-too-long Development environment for applications based on PIC and dsPIC microcontrollers E: piklab unknown-key GPG#8d4d7450 W: piklab strange-permission piklab-0.11.3.desktop.typo-fr.patch 0600 W: piklab strange-permission piklab-0.11.3.x-desktop-fr.patch 0600 W: piklab strange-permission piklab.spec 0600 W: piklab mixed-use-of-spaces-and-tabs (spaces: line 51, tab: line 3)
- rpmlint complains on binary rpm: E: piklab summary-too-long Development environment for applications based on PIC and dsPIC microcontrollers W: piklab dangling-relative-symlink /usr/share/doc/HTML/en/piklab/common ../doc/common /tmp/piklab-0.11.3-1.i686.rpm.18087/usr/share/applications/kde/piklab.desktop: warning: file contains key "DocPath", this key is currently reserved for use within KDE, and should in the future KDE releases be prefixed by "X-"
- Please use http://switch.dl.sourceforge.net/..., so spectool will work properly.
- Qt environment variable was not sourced.
- Duplicate BuildRequires: libart_lgpl-devel (by kdelibs-devel), fam-devel (by kdelibs-devel)
- BuildRequires: gettext is missing (required to build the translations)
- Rpmlint complains on installed package: E: piklab summary-too-long Development environment for applications based on PIC and dsPIC microcontrollers W: piklab dangling-relative-symlink /usr/share/doc/HTML/en/piklab/common ../doc/common //usr/share/applications/kde/piklab.desktop: warning: file contains key "DocPath", this key is currently reserved for use within KDE, and should in the future KDE releases be prefixed by "X-"