Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=791263
--- Comment #11 from Roman Kennke rkennke@redhat.com 2012-02-21 15:03:00 EST ---
Thanks Alexander for the review! I fixed the Issues you mentioned and uploaded a new package:
SPEC: http://icedrobot.de/~roman/mockito/2/mockito.spec SRPM: http://icedrobot.de/~roman/mockito/2/mockito-1.9.0-2.fc16.src.rpm
I also have a number of additional questions:
- The included Maven pom is lacking a bunch of dependencies:
- cglib (and maybe asm) because upstream repackages and includes them in
their own JAR.
- JUnit4 because users of Mockito certainly must include that otherwise
Mockito doesn't make sense.
I suppose I need to patch-in at least the former two. Question: How do we deal with Maven dependency versions? In Maven I need to put an explicit in the dependency, which version should I pick? Do we also need to patch the versions of the existing dependencies (hamcrest, objenesis) to match what is in Fedora?
Yes, adding them to the pom after unbundling is the way. Versions don't matter for Fedora per se because our maven ignores them anyway, so I guess it's up to you and how you want to handle it. The only change would be if you wanted to upstream this patch, which might be tricky.
Well for upstream it'd actually be easy since I can just put any version that is in Maven central and works with Mockito.
I found another problem: it seems like cglib in Fedora doesn't install a pom, even though there seems to be one in Maven central. What should I do with it?
Asm is not used directly by Mockito, only cglib requires and depends on it (transitively), therefore I don't need to put it into mockito's pom.
- rpmlint complains about Requires: cglib, should I leave it out? Does rpm
really figure out that dependency by itself as it claims? And why doesn't it complain about the other libs that I depend on?
Nope, rpmlint just sees "*lib" and thinks it knows, but it doesn't :-) Leave it in or we'd have missing deps.
Ok alright :-)
I'll let Alex continue with the rest :-)
Yep, thanks alot!
Roman