Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590305
--- Comment #5 from Martin Gieseking martin.gieseking@uos.de 2011-01-25 08:42:22 EST --- Hi Mark,
here are some notes on your package:
- The .desktop file isn't installed. See here how to do it: http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
- I recommend to use fully versioned dependencies on vile-common Requires: common = %{version}-%{release}
- please replace the icon file vile.xbm with file vile.xpm as the xbm format is not supported in desktop files (only png, svg and xpm work)
- replace %{_datarootdir} with %{_datadir} to be consistent