https://bugzilla.redhat.com/show_bug.cgi?id=1398922
Yunying Sun yunying.sun@intel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |yunying.sun@intel.com
--- Comment #1 from Yunying Sun yunying.sun@intel.com --- An unformal review:
1. No version specified in %changelog. changelog format: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
2. Static libraries are discouraged. Add "--disable-static" in %configure, and add -devel package where *.so could be included. Refer to: https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Librari... https://fedoraproject.org/wiki/Packaging:Guidelines#DevelPackages
3. Missing %doc for README.md.
4. Use %{name} instead of fixed string "uftrace" would be better in spec file.