https://bugzilla.redhat.com/show_bug.cgi?id=1083941
Antonio Trande anto.trande@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |anto.trande@gmail.com
--- Comment #1 from Antonio Trande anto.trande@gmail.com --- Hi Han.
Just some initial comments.
1. Please, use %{?dist} tag in Release. http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag
2. Vendor is no necessary 3. You don't need to include gcc-c++ as BR http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2
4. List the BR (BuildRequires) packages in multi-lines Too long lines are no good. 5. %configure goes under %build section 6. Put %post/%postun sections before %files See https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overvi...
7. You don't need to use rm, make, chmod, mkdir, cp, sed commands as macro.
8. Libtool archives (*.la files) must NOT be packaged
http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Librarie...
9. Leave a comment when you perform extra commands (like 'chmod ...' or 'rm ...'), in order to clarify your work to the reviewer.