https://bugzilla.redhat.com/show_bug.cgi?id=2121595
Jonathan Wright <jonathan(a)almalinux.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Flags|fedora-review? |fedora-review+
--- Comment #3 from Jonathan Wright <jonathan(a)almalinux.org> ---
(In reply to Jerry James from comment #2)
Thanks for the review!
(In reply to Jonathan Wright from comment #1)
> > BuildRequires: %{py3_dist pip}
> > BuildRequires: %{py3_dist setuptools}
> > BuildRequires: %{py3_dist wheel}
>
> This can all be replaced by the following in %prep: [1]
>
> %generate_buildrequires
> %pyproject_buildrequires
I would urge you to look at retooling towards this method and use `dnf
repoquery` and similar to deal with deps. It will make RPM management easier
for you going forward.
I won't hold up the review over this, of course since nothing explicitly says
it's required.
> > BuildRequires: %{py3_dist pytest}
>
> This one should be replaced with `pytest` or `python3-pytest` instead of the
> %{py3_dist} macro.
I can't find any specific guidance saying it's deprecated or to avoid it so
this is not a blocker of course.
> You need to include the license.
>
> + %license LICENSE
One of the benefits of using the %pyproject* macros is that the license file
is included in the dist-info [1]. In this case, a query shows that the
binary RPM does include the license, and that it is marked as a license:
$ rpm -qL python3-uc-micro-py-1.0.1-1.fc38.noarch.rpm
/usr/lib/python3.11/site-packages/uc_micro_py-1.0.1.dist-info/LICENSE
[1]
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
#_build_macros -- see the %pyproject_save_files description
Doh, my bad.
Package is APPROVED!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2121595