Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=590305
--- Comment #2 from Mark McKinstry mmckinst@nexcess.net 2010-08-17 22:03:14 EDT --- In the time since I submitted this, vile 9.8 has been released so I have updated the spec and SRPM to that version:
Spec URL: http://mmckinst.nexcess.net/vile/vile.spec SRPM URL: http://mmckinst.nexcess.net/vile/vile-9.8-1.fc14.src.rpm
Regarding your comments:
Please use %{version} macro in Source0 line. (The macro is automatically defined by the Version: tag)
Fixed.
Please don't mix "vile" and "%{name}" in %files, just choose one and stick with it.
Fixed.
This package uses GNU autotools, so a plain make %{?_smp_mflags} will do just fine.
Fixed.
There's optional X and Perl support. I think that they should be added, as well.
I looked in to perl but it requires Net::Dict and no RPM exists for it. I'll make an RPM for that later and add in perl support. Regarding X support, xvile should be its own package, rather than part of this vile package here. I might try to do xvile, but 100% of my Linux time is spent without a GUI so I might not be the best person.
Furthermore you must add flex as a BuildRequire:
Added.
The license is not clearly defined
I've updated the License to be GPLv2