Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=594064
--- Comment #5 from Michael Schwendt mschwendt@gmail.com 2010-06-21 06:24:33 EDT ---
Patch: string-include.patch %patch -p1
Do add explicit numbers to patch files to avoid confusion when adding further patches. Start with 0 or 1:
Patch0: string-include.patch %patch0 -p1
Further, it would be a good habit to move the patch files into the package namespace:
Patch0: id3mtag-string-include.patch
And even better, mention also the %version, so the "age" and target of patches become clear:
Patch0: id3mtag-0.78-string-include.patch
#Packager: squell squell@alumina.nl #BuildRoot: %{_tmppath}/%{name}
At least the Packager tag ought to be dropped, since it isn't used within the Fedora Package Collection and -- if commented out -- it only adds ambiguity.
About BuildRoot, either drop it completely or follow the packaging guidelines.