https://bugzilla.redhat.com/show_bug.cgi?id=2259250
--- Comment #2 from Jerry James loganjerry@gmail.com --- Thank you for the review, Tom! Let me know if there is something I can review for you.
(In reply to Tom Rix from comment #1)
lowercase the spec file and %name.
I am going to push back on this. https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_case_sens... says that we should respect upstream naming. I see it spelled with uppercase, HPCombi, everywhere in the distribution. The primary consumer of this package, libsemigroups, also does so; see https://github.com/libsemigroups/libsemigroups.
review %license, from license check and LICENSE file it is GPL 3
Yes, the LICENSE file contains the text of GPL version 3, but the actual version intended by upstream is not stated anywhere. I have asked upstream for clarification: https://github.com/libsemigroups/HPCombi/issues/36.
can you explain # Install documentation with the devel package documentation
%global _docdir_fmt %{name}-devel
I am not sure what you are trying to do here.
That makes the API documentation in HPCombi-doc appear in /usr/share/doc/HPCombi-devel, alongside the documentation files installed by HPCombi-devel. Without that, the API documentation would be in a different directory, /usr/share/doc/HPCombi-doc.
%files doc
%doc %{_vpath_builddir}/doc/html
can you cp/install this to buildroot in the %install
I can, but why? This is very short and simple.
can you check on %check, i get this in my local fedora-review
cd HPCombi-1.0.0
/usr/bin/ctest --test-dir redhat-linux-build --output-on-failure
--force-new-ctest-process -j112 Internal ctest changing into directory: /builddir/build/BUILD/HPCombi-1.0.0/redhat-linux-build
Test project /builddir/build/BUILD/HPCombi-1.0.0/redhat-linux-build
No tests were found!!!
- RPM_EC=0
Yes, that is correct. Upstream has provided no tests. I put the %check section in the spec file in case a future update adds tests and I fail to notice. If you prefer, I can comment it out for now.